Skip to content

Commit

Permalink
Merge pull request #244 from codecrafters-io/remove-copy-app
Browse files Browse the repository at this point in the history
remove COPY app instruction
  • Loading branch information
rohitpaulk authored Aug 14, 2024
2 parents dc938d0 + 08841a0 commit 7abcb31
Show file tree
Hide file tree
Showing 18 changed files with 0 additions and 36 deletions.
2 changes: 0 additions & 2 deletions dockerfiles/crystal-1.1.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
FROM crystallang/crystal:1.1.0-alpine


1 change: 0 additions & 1 deletion dockerfiles/dotnet-6.0.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,3 @@ RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && dotnet build --configuration Rel
RUN chmod +x /codecrafters-precompile.sh

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="codecrafters-redis.csproj,codecrafters-redis.sln"

4 changes: 0 additions & 4 deletions dockerfiles/dotnet-8.0.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,3 @@ RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && dotnet build --configuration Rel
RUN chmod +x /codecrafters-precompile.sh

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="codecrafters-redis.csproj,codecrafters-redis.sln"

# Once the heavy steps are done, we can copy all files back
COPY . /app

3 changes: 0 additions & 3 deletions dockerfiles/gleam-1.0.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,3 @@ RUN mv build /app-cached/build
# Pre-compile steps (legacy)
RUN printf "cd \${CODECRAFTERS_SUBMISSION_DIR} && gleam build" > /codecrafters-precompile.sh
RUN chmod +x /codecrafters-precompile.sh

# Once the heavy steps are done, we can copy all files back
COPY . /app
3 changes: 0 additions & 3 deletions dockerfiles/gleam-1.4.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,3 @@ RUN gleam build
# Cache build directory
RUN mkdir -p /app-cached
RUN mv build /app-cached/build

# Once the heavy steps are done, we can copy all files back
COPY . /app
3 changes: 0 additions & 3 deletions dockerfiles/kotlin-2.0.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,3 @@ COPY --exclude=.git --exclude=README.md . /app

# Cache dependencies
RUN mvn -B package -Ddir=/tmp/codecrafters-build-dir

# Once the heavy steps are done, we can copy all files back
COPY . /app
3 changes: 0 additions & 3 deletions dockerfiles/ocaml-5.2.0.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,3 @@ RUN opam install . --yes

# This runs dune build
RUN .codecrafters/compile.sh

# Once the heavy steps are done, we can copy all files back
COPY . /app
1 change: 0 additions & 1 deletion dockerfiles/php-7.4.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
FROM php:7.4-cli-alpine

RUN docker-php-ext-install sockets

1 change: 0 additions & 1 deletion dockerfiles/php-8.3.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ FROM php:8.3-cli-alpine3.19
RUN apk add --no-cache linux-headers=6.5-r0

RUN docker-php-ext-install sockets

3 changes: 0 additions & 3 deletions dockerfiles/ruby-3.3.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,3 @@ WORKDIR /app
COPY --exclude=.git --exclude=README.md . /app

RUN bundle install --verbose

# Once the heavy steps are done, we can copy all files back
COPY . /app
1 change: 0 additions & 1 deletion dockerfiles/rust-1.43.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,3 @@ RUN rm -f /tmp/codecrafters-redis-target/release/.fingerprint/redis_starter_rust
RUN rm -rf /app/src

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

1 change: 0 additions & 1 deletion dockerfiles/rust-1.54.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,3 @@ RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && cargo build --release --target-d
RUN chmod +x /codecrafters-precompile.sh

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

1 change: 0 additions & 1 deletion dockerfiles/rust-1.62.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,3 @@ RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && cargo build --release --target-d
RUN chmod +x /codecrafters-precompile.sh

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

1 change: 0 additions & 1 deletion dockerfiles/rust-1.68.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,3 @@ RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && cargo build --release --target-d
RUN chmod +x /codecrafters-precompile.sh

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

1 change: 0 additions & 1 deletion dockerfiles/rust-1.70.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,3 @@ RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && cargo build --release --target-d
RUN chmod +x /codecrafters-precompile.sh

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

1 change: 0 additions & 1 deletion dockerfiles/rust-1.76.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,3 @@ RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && cargo build --release --target-d
RUN chmod +x /codecrafters-precompile.sh

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

3 changes: 0 additions & 3 deletions dockerfiles/rust-1.77.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,3 @@ RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && cargo build --release --target-d
RUN chmod +x /codecrafters-precompile.sh

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

# Once the heavy steps are done, we can copy all files back
COPY . /app
3 changes: 0 additions & 3 deletions dockerfiles/zig-0.12.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,3 @@ RUN zig build

RUN printf "set -e \ncd \${CODECRAFTERS_SUBMISSION_DIR} \necho 'Running zig build' \nzig build \necho 'zig build completed.' \n" > /codecrafters-precompile.sh
RUN chmod +x /codecrafters-precompile.sh

# Once the heavy steps are done, we can copy all files back
COPY . /app

0 comments on commit 7abcb31

Please sign in to comment.