CC-1333 Add repository aware caching #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libmartinito
force-pushed
the
add-repository-aware-caching
branch
from
4ff3093 to
3b5ae17
Compare
libmartinito
changed the title
rohitpaulk
reviewed
Jul 1, 2024
| @@ -15,3 +16,6 @@ RUN bun install --frozen-lockfile | |||
| RUN mkdir -p /app-cached | |||
| # If the node_modules directory exists, move it to /app-cached | |||
| RUN if [ -d "/app/node_modules" ]; then mv /app/node_modules /app-cached; fi | |||
|
|
|||
| # Once the heave steps are done, we can copy all files back | |||
rohitpaulk
reviewed
Jul 1, 2024
| @@ -22,3 +23,6 @@ RUN rm -rf /app/src | |||
|
|
|||
| ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock" | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
@libmartinito what's the script you used to generate this? The spacing seems very inconsistent - in some files there are 2 empty lines between blocks, in some there are none - looks very haphazard
rohitpaulk
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.