Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC-1360: refactor logger command to include -n flag with echo #26

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

ryan-gang
Copy link
Contributor

This pull request refactors the logger command in the code to include the -n flag with echo. This ensures that the newline character is not appended to the output, resulting in cleaner and more accurate logging.

Copy link

linear bot commented Aug 8, 2024

@ryan-gang ryan-gang self-assigned this Aug 8, 2024
@ryan-gang ryan-gang requested a review from rohitpaulk August 8, 2024 08:22
Copy link
Member

@rohitpaulk rohitpaulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also make sure to update stage instructions please, in case they use echo without -n

@ryan-gang ryan-gang merged commit 03a606a into main Aug 8, 2024
1 check passed
@ryan-gang ryan-gang deleted the CC-1360 branch August 8, 2024 15:47
@ryan-gang
Copy link
Contributor Author

Yep, done here: codecrafters-io/build-your-own-grep#91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants