Merge pull request #59 from codecrafters-io/redis-repl

Return err if our master server couldn't bind to port.
codecrafters-io · Feb 16, 2024 · 0a63f0b · 0a63f0b
2 parents 1917bfa + 6919562
commit 0a63f0b
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 0 deletions.
diff --git a/internal/test_repl_info_replica.go b/internal/test_repl_info_replica.go
@@ -13,6 +13,7 @@ func testReplInfoReplica(stageHarness *testerutils.StageHarness) error {
 	listener, err := net.Listen("tcp", ":6379")
 	if err != nil {
 		fmt.Println("Error starting TCP server:", err)
+		return err
 	}
 	defer listener.Close()
 	logger := stageHarness.Logger

diff --git a/internal/test_repl_replica_cmd_processing.go b/internal/test_repl_replica_cmd_processing.go
@@ -12,6 +12,7 @@ func testReplCmdProcessing(stageHarness *testerutils.StageHarness) error {
 	listener, err := net.Listen("tcp", ":6379")
 	if err != nil {
 		fmt.Println("Error starting TCP server:", err)
+		return err
 	}
 
 	logger := stageHarness.Logger

diff --git a/internal/test_repl_replica_getack_nonzero.go b/internal/test_repl_replica_getack_nonzero.go
@@ -13,6 +13,7 @@ func testReplGetaAckNonZero(stageHarness *testerutils.StageHarness) error {
 	listener, err := net.Listen("tcp", ":6379")
 	if err != nil {
 		fmt.Println("Error starting TCP server:", err)
+		return err
 	}
 
 	logger := stageHarness.Logger

diff --git a/internal/test_repl_replica_getack_zero.go b/internal/test_repl_replica_getack_zero.go
@@ -12,6 +12,7 @@ func testReplGetaAckZero(stageHarness *testerutils.StageHarness) error {
 	listener, err := net.Listen("tcp", ":6379")
 	if err != nil {
 		fmt.Println("Error starting TCP server:", err)
+		return err
 	}
 
 	logger := stageHarness.Logger

diff --git a/internal/test_repl_replica_psync.go b/internal/test_repl_replica_psync.go
@@ -12,6 +12,7 @@ func testReplReplicaSendsPsync(stageHarness *testerutils.StageHarness) error {
 	listener, err := net.Listen("tcp", ":6379")
 	if err != nil {
 		fmt.Println("Error starting TCP server:", err)
+		return err
 	}
 	logger := stageHarness.Logger
 

diff --git a/internal/test_repl_replica_replconf.go b/internal/test_repl_replica_replconf.go
@@ -11,6 +11,7 @@ func testReplReplicaSendsReplconf(stageHarness *testerutils.StageHarness) error
 	listener, err := net.Listen("tcp", ":6379")
 	if err != nil {
 		fmt.Println("Error starting TCP server:", err)
+		return err
 	}
 	logger := stageHarness.Logger