Merge pull request #139 from codecrafters-io/clarify-resp-value

Refactor RESP to RESP2 error messages and tests

internal/resp/decoder/decode.go

@@ -24,7 +24,7 @@ func doDecodeValue(reader *bytes.Reader) (resp_value.Value, error) {
 	if err == io.EOF {
 		return resp_value.Value{}, IncompleteInputError{
 			Reader:  reader,
-			Message: "Expected start of a new RESP value (either +, -, :, $ or *)",
+			Message: "Expected start of a new RESP2 value (either +, -, :, $ or *)",
 		}
 	}
 
@@ -44,7 +44,7 @@ func doDecodeValue(reader *bytes.Reader) (resp_value.Value, error) {
 
 		return resp_value.Value{}, InvalidInputError{
 			Reader:  reader,
-			Message: fmt.Sprintf("%q is not a valid start of a RESP value (expected +, -, :, $ or *)", string(firstByte)),
+			Message: fmt.Sprintf("%q is not a valid start of a RESP2 value (expected +, -, :, $ or *)", string(firstByte)),
 		}
 	}
 }

internal/resp/decoder/decode_error_tests.yml

@@ -4,13 +4,13 @@
   error: |
     Received: "" (no content received)
                ^ error
-    Error: Expected start of a new RESP value (either +, -, :, $ or *)
+    Error: Expected start of a new RESP2 value (either +, -, :, $ or *)
 
 - input: "K"
   error: |
     Received: "K"
                ^ error
-    Error: "K" is not a valid start of a RESP value (expected +, -, :, $ or *)
+    Error: "K" is not a valid start of a RESP2 value (expected +, -, :, $ or *)
 
 # Simple Strings
 
@@ -102,7 +102,6 @@
                 ^ error
     Error: Invalid integer: "foo", expected a number
 
-
 # Arrays
 
 # - input: "*abc"

internal/test_helpers/fixtures/ping-pong/eof

@@ -8,7 +8,7 @@ Debug = true
 [stage-2] Sent bytes: "*1\r\n$4\r\nPING\r\n"
 [stage-2] Received: "" (no content received)
 [stage-2]            ^ error
-[stage-2] Error: Expected start of a new RESP value (either +, -, :, $ or *)
+[stage-2] Error: Expected start of a new RESP2 value (either +, -, :, $ or *)
 [stage-2] Test failed
 [stage-2] Terminating program
 [stage-2] Program terminated successfully