Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CC-1546: Investigate inconsistent “command not found” between stages [Shell] #81

Merged
merged 4 commits into from
Dec 27, 2024
Merged

CC-1546: Investigate inconsistent “command not found” between stages [Shell] #81

merged 4 commits into from
Dec 27, 2024

Conversation

andy1li
Copy link
Member

@andy1li andy1li commented Dec 24, 2024

No description provided.

@andy1li andy1li self-assigned this Dec 24, 2024
@andy1li andy1li force-pushed the refactor-invalid-command branch 2 times, most recently from 0a1068d to 391f94b Compare December 24, 2024 21:58
@andy1li andy1li changed the title WIP CC-1546: Investigate inconsistent “command not found” between stages [Shell] Dec 24, 2024
@linear Linear
Copy link

linear bot commented Dec 24, 2024

CC-1546 Investigate inconsistent “command not found” between stages [Shell]

@andy1li andy1li requested a review from rohitpaulk December 24, 2024 22:01
rohitpaulk
rohitpaulk reviewed Dec 25, 2024
View reviewed changes
internal/stage6.go Outdated Show resolved Hide resolved
rohitpaulk
rohitpaulk requested changes Dec 25, 2024
View reviewed changes
Copy link
Member

@rohitpaulk rohitpaulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note added!

@andy1li andy1li force-pushed the refactor-invalid-command branch 2 times, most recently from 27f39e3 to a7afd97 Compare December 26, 2024 00:57
@andy1li andy1li force-pushed the refactor-invalid-command branch from a7afd97 to cc85446 Compare December 26, 2024 00:59
@andy1li andy1li requested a review from rohitpaulk December 26, 2024 01:19
rohitpaulk
rohitpaulk requested changes Dec 26, 2024
View reviewed changes
Copy link
Member

@rohitpaulk rohitpaulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added notes on naming

@andy1li
refactor: Consolidate test cases for checking the type of commands an…
8b1ebbd 
…d handling invalid commands in shell testing stages.
@andy1li andy1li requested a review from rohitpaulk December 26, 2024 20:40
rohitpaulk
rohitpaulk requested changes Dec 27, 2024
View reviewed changes
Copy link
Member

@rohitpaulk rohitpaulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added q

andy1li and others added 2 commits December 27, 2024 16:45
@andy1li
refactor(test_cases/type_of_command_test_case): Simplify RunForExecut…
ffda56d 
…able method and remove unnecessary code from RunForBuiltin
@andy1li
Update fixture
b549a75
@andy1li andy1li requested a review from rohitpaulk December 27, 2024 08:52
@andy1li andy1li merged commit c1f6ec6 into main Dec 27, 2024
2 checks passed
@andy1li
Copy link
Member Author

andy1li commented Dec 28, 2024

Thanks, @sgupta98mnit, for highlighting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitpaulk rohitpaulk rohitpaulk approved these changes

Assignees

@andy1li andy1li

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy1li @rohitpaulk