Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generated data classes for parsing #18

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

vladistan
Copy link

@vladistan vladistan commented Aug 1, 2024

This is refactor of the original library.

  • Use generated data classes produced by xsdata library to parse and validate XML file.
  • Use top down parsing to construct dataclass based Atom + GreenButton forest
  • Add some real unit tests
  • Preprocess raw GreenButton data to make it easier to use (at the slight expense of performance)
  • Use typed code eveyrwhere
  • Handle edge cases not present in the sample files. Edge cases were found by running the type validator

@vladistan vladistan force-pushed the gen_code_dataclasses branch 8 times, most recently from aa76923 to d97b943 Compare August 9, 2024 00:21
@vladistan vladistan force-pushed the gen_code_dataclasses branch 3 times, most recently from 6ead669 to 37d34ad Compare August 9, 2024 00:46
@vladistan vladistan marked this pull request as ready for review August 9, 2024 00:48
@AdamFinkle AdamFinkle merged commit b08b4e3 into codeforboston:main Aug 9, 2024
6 checks passed
@vladistan vladistan deleted the gen_code_dataclasses branch August 10, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants