refactor: fix map provider params #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahashim
reviewed
Oct 9, 2023
config/puma.rb
Outdated
| @@ -43,7 +43,7 @@ | |||
| # Workers do not work on JRuby or Windows (both of which do not support | |||
| # processes). | |||
| # | |||
| workers ENV.fetch("WEB_CONCURRENCY", 2) | |||
| workers ENV.fetch("WEB_CONCURRENCY") { 2 } unless Rails.env.development? | |||
There was a problem hiding this comment.
これですが、developmentじゃない時の値がわかりにくいので、workers ENV.fetch("WEB_CONCURRENCY", 1).to_iとかにしてしまって、productionでは環境変数WEB_CONCURRENCYを2とかに設定する、というのではどうでしょうか？（to_iはいらないんでしたっけ？）
There was a problem hiding this comment.
rubocopもここを修正すれば通るかと思います
There was a problem hiding this comment.
どうやらpumaのclusterモードがあまり良くないらしく1台で起動しても同様の現象が起こってしまうようでした...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
提案で、住所の入力が表示されない問題の修正
static providerをglobalのproviderとして使わないようにしました。
📌 Related Issues
📋 Subtasks
CHANGELOGupgrade notes, if required📷 Screenshots (optional)