Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: options of Capybara driver #586

Merged
merged 4 commits into from
Dec 30, 2023
Merged

fix: options of Capybara driver #586

merged 4 commits into from
Dec 30, 2023

Conversation

takahashim
Copy link
Collaborator

🎩 What? Why?

#584 でいったん回避したテストを修正します。

"--headless=new"というオプションを追加しています。

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG upgrade notes, if required
  • If there's a new public field, add it to GraphQL API
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

@takahashim
Copy link
Collaborator Author

どうもlocale周りが安定してなくて、そこだけ少しテストを変更しております…

@takahashim takahashim marked this pull request as ready for review December 18, 2023 15:38
@ayuki-joto ayuki-joto merged commit ee76667 into main Dec 30, 2023
2 checks passed
@takahashim takahashim deleted the fix-capybara-driver branch January 22, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayuki-joto ayuki-joto ayuki-joto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takahashim @ayuki-joto