Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update load_defaults to 6.1 #609

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix: update load_defaults to 6.1 #609

merged 2 commits into from
Jul 10, 2024

Conversation

takahashim
Copy link
Collaborator

@takahashim takahashim commented Jul 9, 2024

🎩 What? Why?

( #608 が先にmainにマージされる前提で作ったPRのため、target branchがそちらになっています。)

#606 の一環で、 #605 に引き続き、config.load_defaultsを6.1まで上げます。

config.action_dispatch.cookies_same_site_protectionconfig.action_controller.urlsafe_csrf_tokensは変更しないようにしています。
この2つの中では、urlsafe_csrf_tokensを先に有効化した方がよいかもしれません。
→確認したところ cookies_same_site_protection はDecidim本体のdecidim-coreで設定されていたため、config.action_controller.urlsafe_csrf_tokensのみ設定を残しています。

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG upgrade notes, if required
  • If there's a new public field, add it to GraphQL API
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

Base automatically changed from enable-use_cookies_with_metadata to main July 10, 2024 09:01
@takahashim takahashim marked this pull request as ready for review July 10, 2024 09:01
@takahashim
Copy link
Collaborator Author

あー、でも cookies_same_site_protection はすでに:laxになってるぽいですね。修正します…

already defined as `:lax` in `decidim-core/lib/decidim/core/engine.rb`.
@ayuki-joto ayuki-joto merged commit a5ea373 into main Jul 10, 2024
2 checks passed
@takahashim takahashim mentioned this pull request Jul 12, 2024
6 tasks
@takahashim takahashim deleted the update-load_defaults-61 branch August 6, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants