-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[이하림] Sprint1 #39
The head ref may contain hidden characters: "Basic-\uC774\uD558\uB9BC"
[이하림] Sprint1 #39
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="UTF-8"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<title>판다마켓</title> | ||
<link rel="stylesheet" href="default.css"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. css 파일도, 어떤 html 파일과 매칭되는지 알 수 있게 명확히 네이밍해주시는 게 좋습니다. |
||
</head> | ||
<body> | ||
<header> | ||
<a href="/"><img src="img\logo\Property 1=sm.png" alt="판다마켓"></a> | ||
<button class="loginBtn">로그인</button> | ||
</header> | ||
<main> | ||
<section class="sect1"> | ||
<div class="homeTop"> | ||
<div class="innerHomeTop"> | ||
<h1>일상의 모든 물건을 거래해 보세요</h1> | ||
<button>구경하러 가기</button> | ||
</div> | ||
<img src="img\landing_page\Img_home_top.png" alt="판다"> | ||
</div> | ||
</section> | ||
<article> | ||
<section class="centerSect"> | ||
<div class="descriptFrame"> | ||
<img src="img\landing_page\Img_home_01.png" alt="인기상품"> | ||
<div class="centerDescript"> | ||
<p class="descript1">Hot item</p> | ||
<p class="descript2">인기 상품을<br>확인해 보세요</p> | ||
<p class="descript3">가장 HOT한 중고거래 물품을<br>판다마켓에서 확인해보세요</p> | ||
</div> | ||
</div> | ||
</section> | ||
<section class="centerSect"> | ||
<div class="descriptFrame"> | ||
<div class="centerDescript"> | ||
<p class="descript1">Search</p> | ||
<p class="descript2">구매를 원하는<br>상품을 검색하세요</p> | ||
<p class="descript3">구매하고 싶은 물품은 검색해서<br>쉽게 찾아보세요</p> | ||
</div> | ||
<img src="img\landing_page\Img_home_02.png" alt="원하는상품검색"> | ||
</div> | ||
</section> | ||
<section class="centerSect"> | ||
<div class="descriptFrame"> | ||
<img src="img\landing_page\Img_home_03.png" alt="판매등록"> | ||
<div class="centerDescript"> | ||
<p class="descript1">Register</p> | ||
<p class="descript2">판매를 원하는<br>상품을 등록하세요</p> | ||
<p class="descript3">어떤 물건이든 판매하고 싶은 상품을<br>쉽게 등록하세요</p> | ||
</div> | ||
</div> | ||
</section> | ||
</article> | ||
<section class="sect2"> | ||
<div class="homeBottom"> | ||
<div> | ||
<h1> | ||
믿을 수 있는<br> | ||
판다 마켓 중고 거래 | ||
</h1> | ||
</div> | ||
Comment on lines
+58
to
+63
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
<img src="img\landing_page\Img_home_bottom.png" alt="판다 소통"> | ||
</div> | ||
</section> | ||
</main> | ||
<footer> | ||
<div> | ||
<span></span> | ||
<span></span> | ||
<span></span> | ||
</div> | ||
</footer> | ||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,137 @@ | ||
*{ | ||
box-sizing: border-box; | ||
margin: 0; | ||
} | ||
header{ | ||
max-width: 1,920px; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 적용되었나요? |
||
height: 70px; | ||
padding: 9px 200px; | ||
border-bottom: 1px; | ||
opacity: 0px; | ||
background: #FFFFFF; | ||
border-bottom: 1px solid #DFDFDF; | ||
display: flex; | ||
align-items: center; | ||
justify-content: space-between; | ||
} | ||
.loginBtn{ | ||
width: 88px; | ||
height: 42px; | ||
top: 20px; | ||
left: 20px; | ||
padding: 12px 23px; | ||
gap: 10px; | ||
border: #3692FF; | ||
border-radius: 8px; | ||
opacity: 0px; | ||
background: #3692FF; | ||
color: #FFFFFF; | ||
} | ||
.canClick:hover{ | ||
cursor: pointer; | ||
} | ||
Comment on lines
+30
to
+32
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 사용하지 않는 선택자는 지워주세요! |
||
.loginBtn:hover{ | ||
background: #1967D6; | ||
} | ||
.sect1, .sect2{ | ||
background: #CFE5FF; | ||
} | ||
Comment on lines
+36
to
+38
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 동일한 스타일을 가지는 요소라면 class를 분리할 필요 없이 범용적인 이름의 class 하나만 생성해 적용해주시면 됩니다. |
||
section{ | ||
max-width: 1920px; | ||
height: 540px; | ||
position: relative; | ||
} | ||
Comment on lines
+39
to
+43
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 태그 선택자는 공용으로 적용해야 하는 경우를 제외하고는 사용을 지양하고 대신 클래스 선택자를 활용하는 연습을 하시는 게 좋습니다. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 리뷰 남기지 않은 다른 부분들도 찾아서 클래스 선택자로 수정해 주세요! |
||
.homeTop{ | ||
position: absolute; | ||
width: 1,110px; | ||
height: 340px; | ||
top: 200px; | ||
left: 405px; | ||
right: 405px; | ||
gap: 20px; | ||
display: flex; | ||
} | ||
.innerHomeTop{ | ||
font-family: Pretendard; | ||
font-size: 25px; | ||
font-weight: 700; | ||
line-height: 56px; | ||
text-align: left; | ||
display: flex; | ||
flex-direction: column; | ||
gap: 20px; | ||
} | ||
.innerHomeTop > button{ | ||
width: 357px; | ||
height: 56px; | ||
padding: 16px 124px; | ||
border: #3692FF; | ||
gap: 10px; | ||
border-radius: 40px; | ||
background: #3692FF; | ||
color: #FFFFFF; | ||
} | ||
.homeBottom{ | ||
width: 1,110px; | ||
height: 397px; | ||
position:absolute; | ||
top: 143px; | ||
left: 405px; | ||
gap: 69px; | ||
opacity: 0px; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. opacity는 0과 1 사이의 숫자값을 작성해야 합니다. |
||
align-items: center; | ||
display: flex; | ||
} | ||
.homeBottom > div{ | ||
width: 295px; | ||
height: 172px; | ||
padding: 0px 0px 60px 0px; | ||
gap: 5px; | ||
opacity: 0px; | ||
} | ||
.homeBottom > div >h1{ | ||
font-family: Pretendard; | ||
font-size: 32px; | ||
font-weight: 900; | ||
line-height: 56px; | ||
text-align: left; | ||
color: #374151; | ||
} | ||
Comment on lines
+73
to
+99
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 새로운 선택자 간에는 가독성을 위해 한 줄씩 띄워주시면 좋습니다.
Comment on lines
+85
to
+99
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 다른 부분에 작성한 리뷰처럼, 태그 선택자의 작성은 지양해 주세요. |
||
|
||
article{ | ||
display: flex; | ||
flex-direction: column; | ||
} | ||
.centerSect{ | ||
max-width: 1920px; | ||
height: 720px; | ||
padding: 138px 466px; | ||
gap: 10px; | ||
} | ||
.descriptFrame{ | ||
max-width: 988px; | ||
height: 444px; | ||
display: flex; | ||
background: #FCFCFC; | ||
|
||
} | ||
.centerDescript{ | ||
display: flex; | ||
flex-direction: column; | ||
gap: 20px; | ||
flex-grow: 1; | ||
justify-content: center; | ||
text-align: left; | ||
position: relative; | ||
left: 100px; | ||
} | ||
|
||
footer{ | ||
width: 1,920px; | ||
height: 160px; | ||
top: 3448px; | ||
padding: 32px 400px; | ||
gap: 10px; | ||
opacity: 0px; | ||
|
||
} | ||
Comment on lines
+129
to
+137
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. width, top, opacity 속성은 적용되지 않았을 것 같네요! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
파일명은 어떤 페이지를 나타내는지 알 수 있도록 명확하게 작성해 주세요!