Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[이하림] Sprint1 #39

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,20 @@

### 기본

- [x]
- []
- []
- [x] 랜딩 페이지의 url path는 루트('/')로 설정합니다.
- [O] title은 "판다마켓"로 설정합니다.
- [X] 화면의 너비가 1920px 이상이면 하늘색 배경색은 너비를 꽉 채우도록 채워지고, 내부 요소들의 위치는 고정되고, 여백만 커지도록 합니다.
- [O] 화면의 너비가 1920px 보다 작아질 때, "판다마켓" 로고의 왼쪽 여백 200px"로그인" 버튼의 오른쪽 여백 200px이 유지되고, 화면의 너비가 작아질수록 두 요소간 거리가 가까워지도록 설정합니다.
- [X] 클릭으로 기능이 동작해야 하는 경우, 사용자가 클릭할 수 있는 요소임을 알 수 있도록 CSS 속성 cursor: pointer 로 설정합니다.
- [X] "판다마켓" 클릭 시 루트 페이지('/')로 이동합니다.
- [X] '로그인'버튼 클릭 시 로그인 페이지('/login')로 이동합니다 (빈 페이지)
- [X] "구경하러가기"버튼 클릭 시('/items')로 이동합니다.(빈 페이지)
- [X] "Privacy Policy", "FAQ"는 클릭 시 각각 Privacy 페이지('/privacy'), FAQ 페이지('/faq')로 이동합니다.(모두 빈 페이지)
- [X] 페이스북, 트위터, 유튜브, 인스타그램 아이콘을 클릭 시 각각의 홈페이지로 새로운 창이 열리면서 이동합니다.

### 심화

- [x]
- [x]사용자의 브라우저가 크고 작아짐에 따라 페이지의 요소간 간격, 요소의 크기, font-size 등 모든 크기와 관련된 값이 크고 작아지도록 설정해 보세요.(설정값은 자유입니다)
- []

## 주요 변경사항
Expand All @@ -18,10 +25,13 @@

## 스크린샷

![image](이미지url)
![image](img\제출이미지\창1.PNG)
![image](img\제출이미지\창2.PNG)
![image](img\제출이미지\창3.PNG)
![image](img\제출이미지\창4.PNG)

## 멘토에게

-
-
- 지금까지 한 코드 중 불필요하거나 효율적이지 않은 부분을 말씀해주셨으면 좋겠습니다.
- 학업으로 해야할게 많아 얼마 하지 못했습니다.
- 셀프 코드 리뷰를 통해 질문 이어가겠습니다.
1 change: 1 addition & 0 deletions 11-Sprint-Mission
Submodule 11-Sprint-Mission added at 4dc5dd
76 changes: 76 additions & 0 deletions Sprint1.html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

파일명은 어떤 페이지를 나타내는지 알 수 있도록 명확하게 작성해 주세요!

Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>판다마켓</title>
<link rel="stylesheet" href="default.css">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

css 파일도, 어떤 html 파일과 매칭되는지 알 수 있게 명확히 네이밍해주시는 게 좋습니다.

</head>
<body>
<header>
<a href="/"><img src="img\logo\Property 1=sm.png" alt="판다마켓"></a>
<button class="loginBtn">로그인</button>
</header>
<main>
<section class="sect1">
<div class="homeTop">
<div class="innerHomeTop">
<h1>일상의 모든 물건을 거래해 보세요</h1>
<button>구경하러 가기</button>
</div>
<img src="img\landing_page\Img_home_top.png" alt="판다">
</div>
</section>
<article>
<section class="centerSect">
<div class="descriptFrame">
<img src="img\landing_page\Img_home_01.png" alt="인기상품">
<div class="centerDescript">
<p class="descript1">Hot item</p>
<p class="descript2">인기 상품을<br>확인해 보세요</p>
<p class="descript3">가장 HOT한 중고거래 물품을<br>판다마켓에서 확인해보세요</p>
</div>
</div>
</section>
<section class="centerSect">
<div class="descriptFrame">
<div class="centerDescript">
<p class="descript1">Search</p>
<p class="descript2">구매를 원하는<br>상품을 검색하세요</p>
<p class="descript3">구매하고 싶은 물품은 검색해서<br>쉽게 찾아보세요</p>
</div>
<img src="img\landing_page\Img_home_02.png" alt="원하는상품검색">
</div>
</section>
<section class="centerSect">
<div class="descriptFrame">
<img src="img\landing_page\Img_home_03.png" alt="판매등록">
<div class="centerDescript">
<p class="descript1">Register</p>
<p class="descript2">판매를 원하는<br>상품을 등록하세요</p>
<p class="descript3">어떤 물건이든 판매하고 싶은 상품을<br>쉽게 등록하세요</p>
</div>
</div>
</section>
</article>
<section class="sect2">
<div class="homeBottom">
<div>
<h1>
믿을 수 있는<br>
판다 마켓 중고 거래
</h1>
</div>
Comment on lines +58 to +63
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • h1, h2 태그와 같은 heading 태그를 사용할 땐 권장되는 사용 방식들이 있습니다. 이미 동일 문서에 h1 태그를 사용했다면, 이후에는 사용을 지양해야 합니다. 참고해 주세요!
    image
  • 비어있는 div로 한 depth 더 감싸신 이유가 있을까요?

<img src="img\landing_page\Img_home_bottom.png" alt="판다 소통">
</div>
</section>
</main>
<footer>
<div>
<span></span>
<span></span>
<span></span>
</div>
</footer>
</body>
</html>
137 changes: 137 additions & 0 deletions default.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
*{
box-sizing: border-box;
margin: 0;
}
header{
max-width: 1,920px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

적용되었나요?

height: 70px;
padding: 9px 200px;
border-bottom: 1px;
opacity: 0px;
background: #FFFFFF;
border-bottom: 1px solid #DFDFDF;
display: flex;
align-items: center;
justify-content: space-between;
}
.loginBtn{
width: 88px;
height: 42px;
top: 20px;
left: 20px;
padding: 12px 23px;
gap: 10px;
border: #3692FF;
border-radius: 8px;
opacity: 0px;
background: #3692FF;
color: #FFFFFF;
}
.canClick:hover{
cursor: pointer;
}
Comment on lines +30 to +32
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사용하지 않는 선택자는 지워주세요!

.loginBtn:hover{
background: #1967D6;
}
.sect1, .sect2{
background: #CFE5FF;
}
Comment on lines +36 to +38
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

동일한 스타일을 가지는 요소라면 class를 분리할 필요 없이 범용적인 이름의 class 하나만 생성해 적용해주시면 됩니다.

section{
max-width: 1920px;
height: 540px;
position: relative;
}
Comment on lines +39 to +43
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

태그 선택자는 공용으로 적용해야 하는 경우를 제외하고는 사용을 지양하고 대신 클래스 선택자를 활용하는 연습을 하시는 게 좋습니다.
해당 css가 적용되는 모든 범위에서의 태그에 반영되기 때문에, 이후 변경 및 수정 등의 유지보수 시 어려움을 겪을 수 있습니다.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 남기지 않은 다른 부분들도 찾아서 클래스 선택자로 수정해 주세요!

.homeTop{
position: absolute;
width: 1,110px;
height: 340px;
top: 200px;
left: 405px;
right: 405px;
gap: 20px;
display: flex;
}
.innerHomeTop{
font-family: Pretendard;
font-size: 25px;
font-weight: 700;
line-height: 56px;
text-align: left;
display: flex;
flex-direction: column;
gap: 20px;
}
.innerHomeTop > button{
width: 357px;
height: 56px;
padding: 16px 124px;
border: #3692FF;
gap: 10px;
border-radius: 40px;
background: #3692FF;
color: #FFFFFF;
}
.homeBottom{
width: 1,110px;
height: 397px;
position:absolute;
top: 143px;
left: 405px;
gap: 69px;
opacity: 0px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opacity는 0과 1 사이의 숫자값을 작성해야 합니다.
내가 작성한 내용이 올바르게 적용되는지 반드시 확인해 주세요!

align-items: center;
display: flex;
}
.homeBottom > div{
width: 295px;
height: 172px;
padding: 0px 0px 60px 0px;
gap: 5px;
opacity: 0px;
}
.homeBottom > div >h1{
font-family: Pretendard;
font-size: 32px;
font-weight: 900;
line-height: 56px;
text-align: left;
color: #374151;
}
Comment on lines +73 to +99
Copy link
Collaborator

@lang92 lang92 Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

새로운 선택자 간에는 가독성을 위해 한 줄씩 띄워주시면 좋습니다.

Comment on lines +85 to +99
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 부분에 작성한 리뷰처럼, 태그 선택자의 작성은 지양해 주세요.
그에 더해서, 자식 선택자(>) 사용 역시 마찬가지의 이유로 구현 상 불가피한 경우가 아니라면 지양해주시는 게 좋습니다.


article{
display: flex;
flex-direction: column;
}
.centerSect{
max-width: 1920px;
height: 720px;
padding: 138px 466px;
gap: 10px;
}
.descriptFrame{
max-width: 988px;
height: 444px;
display: flex;
background: #FCFCFC;

}
.centerDescript{
display: flex;
flex-direction: column;
gap: 20px;
flex-grow: 1;
justify-content: center;
text-align: left;
position: relative;
left: 100px;
}

footer{
width: 1,920px;
height: 160px;
top: 3448px;
padding: 32px 400px;
gap: 10px;
opacity: 0px;

}
Comment on lines +129 to +137
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

width, top, opacity 속성은 적용되지 않았을 것 같네요!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개발자도구 elements 패널의 하단 styles 탭에서 특정 요소에 적용되는 스타일을 확인하실 수 있습니다.
image

Binary file added img/landing_page/Img_home_01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/desktop_01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/desktop_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/desktop_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/desktop_04.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/desktop_05.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/mobile_01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/mobile_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/mobile_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/mobile_04.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/mobile_05.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/tablet_01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/tablet_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/tablet_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/tablet_04.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/landing_page/img/landing/tablet_05.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/logo/Img_inquiry_empty.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/logo/Img_reply_empty.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/logo/Property 1=Typo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/logo/Property 1=Typo@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/logo/Property 1=Typo@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/logo/Property 1=lg.png
Binary file added img/logo/Property 1=lg@2x.png
Binary file added img/logo/Property 1=lg@3x.png
Binary file added img/logo/Property 1=md.png
Binary file added img/logo/Property 1=md@2x.png
Binary file added img/logo/Property 1=md@3x.png
Binary file added img/logo/Property 1=sm.png
Binary file added img/logo/Property 1=sm@2x.png
Binary file added img/logo/Property 1=sm@3x.png
Binary file added img/logo/img_default.png
Binary file added img/제출이미지/창1.PNG
Binary file added img/제출이미지/창2.PNG
Binary file added img/제출이미지/창3.PNG
Binary file added img/제출이미지/창4.PNG
Loading