Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[이학수] Sprint1 #5

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions faq.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>FAQ | 판다마켓</title>
<!-- pretendard web-font: https://github.com/orioncactus/pretendard -->
<link rel="stylesheet" as="style" crossorigin href="https://cdn.jsdelivr.net/gh/orioncactus/pretendard@v1.3.9/dist/web/static/pretendard.min.css">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<link rel="stylesheet" as="style" crossorigin href="https://cdn.jsdelivr.net/gh/orioncactus/pretendard@v1.3.9/dist/web/static/pretendard.min.css">
<link rel="stylesheet" as="style" crossorigin href="https://cdn.jsdelivr.net/gh/orioncactus/pretendard@v1.3.9/dist/web/static/pretendard.min.css" media="print" onload="this.media='all'">

웹 폰트를 사용할 때, 성능에 대해서도 고민을 하면 좋습니다. 😸

  1. media="print"
    브라우저가 이 스타일시트를 즉시 로드하지 않습니다. 대신, 페이지의 주요 콘텐츠가 먼저 로드됩니다. 즉, 필요에 따라 지연로딩을 하게 설정할 수 있어요.
  2. onload="this.media='all'
    스타일시트가 완전히 로드된 후에 이 JavaScript 코드가 실행됩니다.

이렇게 하는 경우, 초기 페이지 로드 시간 단축할 수 있습니다. (즉, 폰트 스타일시트가 페이지 렌더링을 차단하지 않습니다.)

<link rel="stylesheet" href="style.css">
<link rel="icon" href="favicon.png" type="image/png">
</head>

<body>
<div class="wrap">
<header id="header">
<div class="container header">
<h1 class="site-name">
<a href="/" class="root-link">
<img src="img/logo.png" alt="로고 이미지" class="logo">
<img src="img/site-name.png" alt="판다마켓">
</a>
</h1>
<a href="/login.html" class="btn">로그인</a>
</div>
<!-- /.container -->
</header>

<section class="section">
<div class="container">
<h2>FAQ</h2>
</div>
<!-- /.container -->
</section>
<!-- /.section -->

Comment on lines +24 to +35
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

불필요한 주석은 제거되면 좋겠습니다. 🙃

<div class="bottom-visual bg-sky">
<div class="container">
<h2 class="heading">믿을 수 있는<br>판다마켓 중고 거래</h2>
</div>
<!-- /.container -->
</div>
<!-- / bottom-visual -->
Comment on lines +40 to +42
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멘토님 혹시 이거 주석 어떻게 없애염?


<footer id="footer">
<div class="container">
<p class="cr">&copy;codeit - 2024</p>
<ul class="links">
<li><a href="privacy.html">Privacy Policy</a></li>
<li><a href="faq.html">FAQ</a></li>
</ul>
Comment on lines +47 to +50
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ul class="links">
<li><a href="privacy.html">Privacy Policy</a></li>
<li><a href="faq.html">FAQ</a></li>
</ul>
<nav aria-label="footer navigation">
<ul class="links">
<li><a href="privacy.html">Privacy Policy</a></li>
<li><a href="faq.html">FAQ</a></li>
</ul>
<nav>

지금도 충분히 시멘틱하게 잘 해주셨지만, 네비게이션의 경우 메뉴를 nav 태그와 접근성을 위한 aria-label 까지 사용해주면 더 좋겠습니다. 웹표준을 따라 작성하면 문서의 구조와 의미를 보다 더 정확하게 검색엔진과 스크린리더에 전달할 수 있으니까요. 😄

<ul class="sns">
<li>
<a href="https://www.facebook.com/" target="_blank">
<img src="img/ico-facebook.png" alt="FaceBook">
</a>
</li>
<li>
<a href="https://x.com/" target="_blank">
<img src="img/ico-twitter.png" alt="X">
</a>
</li>
<li>
<a href="https://youtube.com/" target="_blank">
<img src="img/ico-youtube.png" alt="Youtube">
</a>
Comment on lines +63 to +65
Copy link
Collaborator

@arthurkimdev arthurkimdev Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="https://youtube.com/" target="_blank">
<img src="img/ico-youtube.png" alt="Youtube">
</a>
<a href="https://youtube.com/" target="_blank" rel="noopener noreferrer">
<img src="img/ico-youtube.png" alt="Youtube">
</a>

target="_blank" 를 사용하여 새 탭이나 새 창에서 링크를 열 때, 열린 새 페이지는 window.opener 객체를 통해 원래 페이지에 접근할 수 있습니다. 이는 잠재적인 보안 위험으로 아래처럼 rel="noopener"를 사용하여 window.opener 참조를 제거를 통해 원래 페이지에 접근할 수 없도록 설정해야 합니다.

</li>
<li>
<a href="https://www.instagram.com/" target="_blank">
<img src="img/ico-instagram.png" alt="Instagram">
</a>
</li>
</ul>
</div>
<!-- /.container -->
</footer>
<!-- / footer -->
</div>
<!-- / wrap -->
</body>
</html>
Binary file added favicon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/bg-bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/bg-hero.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/hot-item.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ico-facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ico-instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ico-twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ico-youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/register.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/search.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/site-name.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
120 changes: 120 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>판다마켓</title>
<!-- pretendard web-font: https://github.com/orioncactus/pretendard -->
<link rel="stylesheet" as="style" crossorigin href="https://cdn.jsdelivr.net/gh/orioncactus/pretendard@v1.3.9/dist/web/static/pretendard.min.css">
<link rel="stylesheet" href="style.css">
<link rel="icon" href="favicon.png" type="image/png">
</head>

<body>
<div class="wrap">
<header id="header">
<div class="container header">
<h1 class="site-name">
<a href="/" class="root-link">
<img src="img/logo.png" alt="로고 이미지" class="logo">
<img src="img/site-name.png" alt="판다마켓">
</a>
</h1>
<a href="/login.html" class="btn">로그인</a>
</div>
<!-- /.container -->
</header>

<div class="hero bg-sky">
<div class="container">
<h2 class="hero heading">일상의 모든 물건을<br>거래해 보세요</h2>
<a href="/items.html" class="btn rounded">구경하러 가기</a>
</div>
<!-- /.container -->
</div>
<!-- /.hero -->

<section class="section">
<div class="container">
<img src="img/hot-item.png" alt="" class="section-img">
<div class="section-content">
<span class="section-point">Hot item</span>
<h2 class="section-title">인기상품을<br>확인해 보세요</h2>
<p class="section-desc">가장 HOT한 중고거래 물품을 판다 마켓에서 확인해 보세요</p>
</div>
</div>
<!-- /.container -->
</section>
<!-- /.section -->

<section class="section">
<div class="container">
<div class="section-content right">
<span class="section-point">Search</span>
<h2 class="section-title">구매를 원하는<br>상품을 검색하세요</h2>
<p class="section-desc">구매하고 싶은 물품은 검색해서 쉽게 찾아보세요</p>
</div>
<img src="img/search.png" alt="" class="section-img right">
</div>
<!-- /.container -->
</section>
<!-- /.section -->

<section class="section">
<div class="container">
<img src="img/register.png" alt="" class="section-img">
<div class="section-content">
<span class="section-point">Register</span>
<h2 class="section-title">판매를 원하는<br>상품을 등록하세요</h2>
<p class="section-desc">어떤 물건이든 판매하고 싶은 상품을 쉽게 등록하세요</p>
</div>
</div>
<!-- /.container -->
</section>
<!-- /.section -->

<div class="bottom-visual bg-sky">
<div class="container">
<h2 class="heading">믿을 수 있는<br>판다마켓 중고 거래</h2>
</div>
<!-- /.container -->
</div>
<!-- / bottom-visual -->

<footer id="footer">
<div class="container">
<p class="cr">&copy;codeit - 2024</p>
<ul class="links">
<li><a href="privacy.html">Privacy Policy</a></li>
<li><a href="faq.html">FAQ</a></li>
</ul>
<ul class="sns">
<li>
<a href="https://www.facebook.com/" target="_blank">
<img src="img/ico-facebook.png" alt="FaceBook">
</a>
</li>
<li>
<a href="https://x.com/" target="_blank">
<img src="img/ico-twitter.png" alt="X">
</a>
</li>
<li>
<a href="https://youtube.com/" target="_blank">
<img src="img/ico-youtube.png" alt="Youtube">
</a>
</li>
<li>
<a href="https://www.instagram.com/" target="_blank">
<img src="img/ico-instagram.png" alt="Instagram">
</a>
</li>
</ul>
</div>
<!-- /.container -->
</footer>
<!-- / footer -->
</div>
<!-- / wrap -->
</body>
</html>
80 changes: 80 additions & 0 deletions items.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Item | 판다마켓</title>
<!-- pretendard web-font: https://github.com/orioncactus/pretendard -->
<link rel="stylesheet" as="style" crossorigin href="https://cdn.jsdelivr.net/gh/orioncactus/pretendard@v1.3.9/dist/web/static/pretendard.min.css">
<link rel="stylesheet" href="style.css">
<link rel="icon" href="favicon.png" type="image/png">
</head>

<body>
<div class="wrap">
<header id="header">
<div class="container header">
<h1 class="site-name">
<a href="/" class="root-link">
<img src="img/logo.png" alt="로고 이미지" class="logo">
<img src="img/site-name.png" alt="판다마켓">
</a>
</h1>
<a href="/login.html" class="btn">로그인</a>
</div>
<!-- /.container -->
</header>

<section class="section">
<div class="container">
<h2>Item</h2>
</div>
<!-- /.container -->
</section>
<!-- /.section -->

<div class="bottom-visual bg-sky">
<div class="container">
<h2 class="heading">믿을 수 있는<br>판다마켓 중고 거래</h2>
</div>
<!-- /.container -->
</div>
<!-- / bottom-visual -->

<footer id="footer">
<div class="container">
<p class="cr">&copy;codeit - 2024</p>
<ul class="links">
<li><a href="privacy.html">Privacy Policy</a></li>
<li><a href="faq.html">FAQ</a></li>
</ul>
<ul class="sns">
<li>
<a href="https://www.facebook.com/" target="_blank">
<img src="img/ico-facebook.png" alt="FaceBook">
</a>
</li>
<li>
<a href="https://x.com/" target="_blank">
<img src="img/ico-twitter.png" alt="X">
</a>
</li>
<li>
<a href="https://youtube.com/" target="_blank">
<img src="img/ico-youtube.png" alt="Youtube">
</a>
</li>
<li>
<a href="https://www.instagram.com/" target="_blank">
<img src="img/ico-instagram.png" alt="Instagram">
</a>
</li>
</ul>
</div>
<!-- /.container -->
</footer>
<!-- / footer -->
</div>
<!-- / wrap -->
</body>
</html>
80 changes: 80 additions & 0 deletions login.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Login | 판다마켓</title>
<!-- pretendard web-font: https://github.com/orioncactus/pretendard -->
<link rel="stylesheet" as="style" crossorigin href="https://cdn.jsdelivr.net/gh/orioncactus/pretendard@v1.3.9/dist/web/static/pretendard.min.css">
<link rel="stylesheet" href="style.css">
<link rel="icon" href="favicon.png" type="image/png">
</head>

<body>
<div class="wrap">
<header id="header">
<div class="container header">
<h1 class="site-name">
<a href="/" class="root-link">
<img src="img/logo.png" alt="로고 이미지" class="logo">
<img src="img/site-name.png" alt="판다마켓">
</a>
</h1>
<a href="/login.html" class="btn">로그인</a>
</div>
<!-- /.container -->
</header>

<section class="section">
<div class="container">
<h2>Login</h2>
</div>
<!-- /.container -->
</section>
<!-- /.section -->

<div class="bottom-visual bg-sky">
<div class="container">
<h2 class="heading">믿을 수 있는<br>판다마켓 중고 거래</h2>
</div>
<!-- /.container -->
</div>
<!-- / bottom-visual -->

<footer id="footer">
<div class="container">
<p class="cr">&copy;codeit - 2024</p>
<ul class="links">
<li><a href="privacy.html">Privacy Policy</a></li>
<li><a href="faq.html">FAQ</a></li>
</ul>
<ul class="sns">
<li>
<a href="https://www.facebook.com/" target="_blank">
<img src="img/ico-facebook.png" alt="FaceBook">
</a>
</li>
<li>
<a href="https://x.com/" target="_blank">
<img src="img/ico-twitter.png" alt="X">
</a>
</li>
<li>
<a href="https://youtube.com/" target="_blank">
<img src="img/ico-youtube.png" alt="Youtube">
</a>
</li>
<li>
<a href="https://www.instagram.com/" target="_blank">
<img src="img/ico-instagram.png" alt="Instagram">
</a>
</li>
</ul>
</div>
<!-- /.container -->
</footer>
<!-- / footer -->
</div>
<!-- / wrap -->
</body>
</html>
Loading
Loading