-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[최제원] Sprint2 #102
Merged
1005hoon
merged 4 commits into
codeit-bootcamp-frontend:Basic-최제원
from
CJewon:Basic-최제원-sprint2
Nov 7, 2024
The head ref may contain hidden characters: "Basic-\uCD5C\uC81C\uC6D0-sprint2"
Merged
[최제원] Sprint2 #102
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b349d93
div태그 대신 header 태그로 변경 및 logo-img에 대한 a태그 추가
CJewon 0c982da
이미지 파일구조 수정 및 파일구조 수정에 따른 이미지들의 src 수정
CJewon 3816e1b
login.html form태그와 label태그로 변경 및 비밀번호 가림 이미지 추가와 그에 맞는 css 적용
CJewon be7188f
signup.html form태그와 label태그로 변경 및 비밀번호 가림 이미지 추가와 그에 맞는 css 적용
CJewon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
Binary file not shown.
Binary file not shown.
Binary file not shown.
File renamed without changes
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,52 +9,64 @@ | |
</head> | ||
<body> | ||
<section class="login"> | ||
<div class="logo__container"> | ||
<img src="/img/login/큰판다얼굴.png" alt="판다얼굴" class="logo__img" /> | ||
<header class="logo__container"> | ||
<a href="/" class="logo-img__link"> | ||
<img src="/img/큰판다얼굴.png" alt="판다얼굴" class="logo__img" /> | ||
</a> | ||
<a href="/" class="logo__link"><h1>판다마켓</h1></a> | ||
</div> | ||
</header> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good 👍🏻 |
||
<div class="login__container"> | ||
<div class="input-email__container"> | ||
<p class="input-email__text">이메일</p> | ||
<input | ||
type="text" | ||
placeholder="이메일을 입력해주세요" | ||
class="input-email" | ||
/> | ||
</div> | ||
<div class="input-password__container"> | ||
<p class="input-password__text">비밀번호</p> | ||
<input | ||
type="password" | ||
name="userPassword" | ||
id="password" | ||
placeholder="비밀번호를 입력해주세요" | ||
class="input-password" | ||
/> | ||
</div> | ||
<a href="/login" class="login-button">로그인</a> | ||
<div class="sns-login__container"> | ||
<form action="/login" method="POST" class="form__container"> | ||
<div class="form__group"> | ||
<label class="form__group-label" for="focus">이메일</label> | ||
<input | ||
type="email" | ||
placeholder="이메일을 입력해주세요" | ||
class="form__group-input" | ||
name="email" | ||
/> | ||
</div> | ||
<div class="form__group"> | ||
<label class="form__group-label" for="focus">비밀번호</label> | ||
<div class="form__group-input-container"> | ||
<input | ||
type="password" | ||
name="password" | ||
id="password" | ||
placeholder="비밀번호를 입력해주세요" | ||
class="form__group-input" | ||
/> | ||
<img | ||
src="/img/btn_visibility_on_24px.png" | ||
alt="비밀번호 가림 이미지" | ||
class="form__group-img" | ||
/> | ||
</div> | ||
</div> | ||
<button type="submit" class="login-button">로그인</button> | ||
</form> | ||
<div class="social-login__container"> | ||
<p>간편 로그인하기</p> | ||
<div class="sns-login__icon"> | ||
<div class="social-login__icon"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good 👍🏻 |
||
<a href="https://www.google.com/"> | ||
<img | ||
src="/img/login/google-icon.png" | ||
src="/img/google-icon.png" | ||
alt="구글 아이콘" | ||
class="sns-login__google-icon" | ||
class="social-login__google-icon" | ||
/> | ||
</a> | ||
<a href="“https://www.kakaocorp.com/page/"> | ||
<img | ||
src="/img/login/kakaotalk-icon.png" | ||
src="/img/kakaotalk-icon.png" | ||
alt="카카오톡 아이콘" | ||
class="sns-login__kakao-icon" | ||
class="social-login__kakao-icon" | ||
/> | ||
</a> | ||
</div> | ||
</div> | ||
<div class="sign-up__container"> | ||
<p>판다마켓이 처음이신가요?</p> | ||
<a href="/signup" class="sign-up__link">회원가입</a> | ||
<a href="/signup.html" class="sign-up__link">회원가입</a> | ||
</div> | ||
</div> | ||
</section> | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엇 굳이
.html
을 안붙여도 되지 않나요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/login 으로 했을경우 사진과 같이 나와서 .html을 붙여줬습니다. 혹여 문제가 될까요 ?