Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub-actions [Fix] delete merged branch github action
devToram
approved these changes
Nov 26, 2024
| </div> | ||
| <div> | ||
| <a href="https://ko-kr.facebook.com/"> | ||
| <img src="./img/Vector.png"> |
|
|
||
| //Email Validation | ||
| function validateEmail(email) { | ||
| const regex = /^[A-Za-z0-9_\.\-]+@[A-Za-z0-9\-]+/; |
There was a problem hiding this comment.
정규표현식의 경우 따로 상수화 시켜주시지 않으면 해당 함수가 실행될 때마다 상수가 선언되어요!
밖으로 빼주시는 것을 추천드립니다!
Suggested change
| const regex = /^[A-Za-z0-9_\.\-]+@[A-Za-z0-9\-]+/; | |
| const REGEX = /^[A-Za-z0-9_\.\-]+@[A-Za-z0-9\-]+/; |
|
|
||
| //Password Validation | ||
| function validatePassword(password) { | ||
| return password.length >= 8; |
There was a problem hiding this comment.
8 이라는 상수값도 따로 어떤 수인지를 알기 쉽게 상수로 정의해주시면 좋을 거 같아요!
Suggested change
| return password.length >= 8; | |
| const MINIMUM_PW_LENGTH = 8 | |
| .... | |
| return password.length >= MINIMUM_PW_LENGTH; |
Comment on lines
+21
to
+25
| emailInput.classList.add("login-form__input--error"); | ||
| emailError = document.createElement('p'); | ||
| emailError.textContent = '잘못된 이메일 형식입니다.'; | ||
| emailError.classList.add('login-form__input--error-message'); | ||
| emailInput.parentElement.appendChild(emailError); |
There was a problem hiding this comment.
실제 DOM 을 추가하는 방식은 sideEffect 가 많을 수 있어서 className 으로 속성을 제어하는 방식도 고려해보심 좋을 거 같아요!
| } | ||
|
|
||
| // Create Passweord Error Message | ||
| function passwordError(input) { |
There was a problem hiding this comment.
위의 emailError 와 공통된 부분이 많아 공통화해보시면 좋을 거 같습니다!
| const [pageSize, setPageSize] = useState("10"); | ||
| const [itemList, setItemList] = useState([]); | ||
| const [keyword, setKeyword] = useState(""); | ||
| const [totalPageNum, setTotalPageNum] = useState(); |
There was a problem hiding this comment.
num 인데 초기값이 undefined 네요~ 의도하신 게 아니라면 number 값을 지정해주세요!
Comment on lines
+14
to
+16
| const handleNewestClick = () => setOrderBy("recent"); | ||
|
|
||
| const handleFavoriteClick = () => setOrderBy("favorite"); |
There was a problem hiding this comment.
하나의 함수로 만들고 파라미터로 값을 받는 방법을 쓰면 중복이 줄 거 같아요!
Suggested change
| const handleNewestClick = () => setOrderBy("recent"); | |
| const handleFavoriteClick = () => setOrderBy("favorite"); | |
| const handle�OrderChangeClick = (chosenOrder) => setOrderBy(chosenOrder); |
Comment on lines
+29
to
+38
| const getPageSize = () => { | ||
| const width = window.innerWidth; | ||
| if (width < 768) { | ||
| return 4; | ||
| } else if (width < 1280) { | ||
| return 6; | ||
| } else { | ||
| return 10; | ||
| } | ||
| }; |
There was a problem hiding this comment.
상수값들을 쓰실 때는 const 로 빼주셔서 의미를 나타내시거나 주석으로 어떤 값인지 적어주시면 이해하기 좋을 거 같아요!
| </div> | ||
| </div> | ||
| <div className="allItemsCardSection"> | ||
| {itemList?.map((item) => ( |
| const [itemList, setItemList] = useState([]); | ||
| const [pageSize, setPageSize] = useState("4"); | ||
|
|
||
| const getPageSize = () => { |
There was a problem hiding this comment.
중복되는 코드들은 util 화해서 공통화해보심 좋을 거 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github에 PR(Pull Request)을 만들어서 미션을 제출합니다.
피그마 디자인에 맞게 페이지를 만들어 주세요.
React를 사용합니다
스크린샷
멘토에게
미완성 제출하겠습니다.