-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[소중모] Sprint 1 #32
The head ref may contain hidden characters: "Basic-\uC18C\uC911\uBAA8"
[소중모] Sprint 1 #32
Conversation
제가 올린 방식이 잘못 되었다고 생각하는데 정확한 방식도 알 수 있을까요? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드는 너무 잘 짜주셨는데, 커밋이 이상하게 3번 반복해서 들어왔네요ㅎㅎ
혹시 해결안되시면 다음 시간에 라이브 코드리뷰 요청해주시면 중복 부분 같이 해결해봐요!
<body> | ||
<header> | ||
<a href="/"><img src="pandamarket.png" alt="판다마켓"></a> | ||
<a href="login.html" id="loginButton" class="button">로그인</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id 보다는 특별한 이름의 class를 지정해주시는 걸 추천드려요! (id 는 훨씬 더 특별한 친구를 위해 아껴두는 걸로..!)
|
||
<section class="picture"> | ||
<div class="feature"> | ||
<img src="Img_home_01.png" alt="인기 상품"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이미지에 alt 넣어주신 거 👍 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
인덴트가 깔끔하고, 코드가 읽기 쉽네요!! 💯
요구사항
처음이라 잘 올렸는지 모르겠네요...
기본
심화
주요 변경사항
스크린샷
멘토에게