[최성락] sprint1 #47
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| img/ |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
|
There was a problem hiding this comment. 이 영역도 위와 마찬가지에요! |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
|
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="ko"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| <title>판다마켓</title> | ||
| </head> | ||
|
|
||
| <body> | ||
| <header> | ||
| <a href="/" class="logo-img" | ||
| ><img src="img/Property 1=md.png" alt="로고" | ||
| /></a> | ||
| <a href="/login" class="login">로그인</a> | ||
| </header> | ||
| <div class="container"> | ||
|
There was a problem hiding this comment.
태그 안에서 , 는 잘 나누어 주셨는데 이부분이 조금 아쉽네요
`` 이렇게 하고 위 div태그는 없어지는 편이 좀 더 좋을것 같습니다 ㅎ
|
||
| <main> | ||
| <section class="banner"> | ||
| <div class="banner-section"> | ||
|
Comment on lines
+19
to
+20
There was a problem hiding this comment. 여기도요 ㅎ 굳이 <section class="banner">
<div class="banner-section">
...과 같은 중첩 구조가 필요했을까 싶긴 하네요 ㅎ 그냥 |
||
| <div> | ||
| <span>일상의 모든 물건을<br />거래해 보세요</span> | ||
| <a href="/items" class="item-link">구경하러 가기</a> | ||
| </div> | ||
| <div> | ||
| <img | ||
| src="img/Img_home_top.png" | ||
| alt="상단 이미지" | ||
|
There was a problem hiding this comment.
|
||
| class="banner img" | ||
|
There was a problem hiding this comment. class도 여러개를 조합해서 사용하는거 너무 좋아요! |
||
| /> | ||
| </div> | ||
| </div> | ||
| </section> | ||
|
|
||
| <section class="main-content"> | ||
| <img src="img/desktop_02.png" alt="메인 이미지 1" /> | ||
| </section> | ||
|
|
||
| <section class="main-content"> | ||
| <img src="img/desktop_03.png" alt="메인 이미지 2" /> | ||
| </section> | ||
|
|
||
| <section class="main-content"> | ||
| <img src="img/desktop_04.png" alt="메인 이미지 3" /> | ||
| </section> | ||
|
|
||
| <section class="banner"> | ||
| <div class="banner-section"> | ||
| <div> | ||
| <span>믿을 수 있는<br />판다마켓 중고 거래</span> | ||
| </div> | ||
|
|
||
| <div> | ||
| <img | ||
| src="img/Img_home_bottom.png" | ||
| alt="하단 이미지" | ||
| class="banner img" | ||
| /> | ||
| </div> | ||
| </div> | ||
| </section> | ||
| </main> | ||
|
|
||
| <footer> | ||
| <div class="footer-content"> | ||
| <div class="footer-copyright"> | ||
| <span>©codeit - 2024</span> | ||
| </div> | ||
| <div class="footer-info"> | ||
| <span><a href="/privacy">Privacy Policy</a></span> | ||
| <span><a href="/faq">FAQ</a></span> | ||
| </div> | ||
| <div class="footer-social"> | ||
| <a href="https://facebook.com" target="_blank" | ||
| ><img src="img/Vector.png" alt="페이스북" class="social-link" | ||
| /></a> | ||
| <a href="https://x.com" target="_blank" | ||
| ><img src="img/Vector-1.png" alt="트위터" class="social-link" | ||
| /></a> | ||
| <a href="https://youtube.com" target="_blank" | ||
| ><img src="img/Vector-2.png" alt="유튜브" class="social-link" | ||
| /></a> | ||
| <a href="https://instagram.com" target="_blank" | ||
| ><img src="img/Vector-3.png" alt="인스타그램" class="social-link" | ||
| /></a> | ||
| </div> | ||
| </div> | ||
| </footer> | ||
| </div> | ||
| </body> | ||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,155 @@ | ||
| * { | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| body { | ||
| font-family: Arial, sans-serif; | ||
| margin: 0; | ||
| padding: 0; | ||
| height: 100vh; | ||
|
There was a problem hiding this comment. 여기 height는 굳이 없어도 될것 같다는 생각이 드네요 ㅎ |
||
| } | ||
|
|
||
| a { | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .container { | ||
| width: 100%; | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
| header { | ||
| width: 100%; | ||
| height: 70px; | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| padding: 9px 200px; | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
| .logo-img { | ||
| display: flex; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .login { | ||
| background-color: #3692FF ; | ||
| color: #F3F4F6; | ||
| text-decoration: none; | ||
| line-height: 26px; | ||
| font-weight: 600; | ||
| width: 128px; | ||
| height: 48px; | ||
| border-radius: 8px; | ||
| padding: 12px 23px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| .button.login:hover { | ||
| background-color: #1967D6 ; | ||
| } | ||
|
|
||
| .banner { | ||
| width: 100%; | ||
| height: 540px; | ||
| position: relative; | ||
| background-color: #CFE5FF ; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: flex-end; | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
| .banner.img { | ||
| width: 746px; | ||
| height: 340px; | ||
| } | ||
|
|
||
| .banner span { | ||
| display: block; | ||
| font-size: 40px; | ||
| font-weight: 700; | ||
| color: #374151; | ||
| position: relative; | ||
| line-height: 56px; | ||
| top: 30px; | ||
| margin-bottom: 60px; | ||
| } | ||
|
|
||
| .banner-section{ | ||
| display: flex; | ||
| justify-content: space-between; | ||
| width: 1110px; | ||
|
There was a problem hiding this comment. 이런 부분은 만약 viewport가 1110px 미만이라면 해당 코드로 인해 가로 스크롤이 생기고 말거에요 ㅎ |
||
| height: 340px; | ||
| } | ||
|
|
||
| .banner-section div:first-child { | ||
| flex: 1; | ||
| } | ||
|
|
||
| .banner-section div:last-child { | ||
| flex: 1; | ||
| flex-shrink: 2; | ||
| } | ||
|
|
||
| .item-link { | ||
| background-color: #3692FF; | ||
| padding: 16px 124px; | ||
| border-radius: 40px; | ||
| font-size: 20px; | ||
| line-height: 24px; | ||
| font-weight: 600; | ||
| color: #ffffff; | ||
| text-decoration: none; | ||
| } | ||
|
|
||
| .item-link:hover, | ||
| .login:hover { | ||
| background-color: #1967D6; | ||
| } | ||
|
|
||
|
|
||
| .main-content { | ||
| height: 720px; | ||
| width: 100%; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
| footer { | ||
| width: 100%; | ||
| height: 160px; | ||
| background-color: #111827; | ||
| } | ||
|
|
||
| .footer-content { | ||
| display: flex; | ||
| justify-content: space-between; | ||
| width: 1120px; | ||
| margin: 0 auto; | ||
| padding: 40px 0; | ||
| } | ||
|
|
||
| .footer-copyright { | ||
| color: #9CA3AF; | ||
| } | ||
|
|
||
| .footer-info { | ||
| display: flex; | ||
| gap: 15px; | ||
| } | ||
|
|
||
| .footer-info span a { | ||
| color: #E5E7EB; | ||
| text-decoration: none; | ||
| } | ||
|
|
||
| .footer-social { | ||
| display: flex; | ||
| gap: 15px; | ||
| align-items: center; | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이부분은 왼쪽 영역만 이미지로 추출하고 오른쪽 영역은 직접 html과 css로 만드셨어야 합니다!