[김태욱]Sprint1 #22
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Document</title> | ||
| </head> | ||
| <body> | ||
|
|
||
| </body> | ||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,171 @@ | ||
| * { | ||
| margin: 0; | ||
| padding: 0; | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| body { | ||
| color: #374151; | ||
| word-break: keep-all; | ||
| font-family: "Pretendard", sans-serif; | ||
| } | ||
|
|
||
| img { | ||
| vertical-align: bottom; | ||
| } | ||
|
|
||
| h1 { | ||
| font-size: 40px; | ||
| font-weight: 700; | ||
| line-height: 56px; | ||
| letter-spacing: 0.02em; | ||
| } | ||
|
|
||
| /* 헤더 부분 */ | ||
| header { | ||
| width: 100%; | ||
| height: 70px; | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| padding: 0 200px; | ||
| background-color: #ffffff; | ||
| border-bottom: 1px solid #dfdfdf; | ||
| } | ||
|
|
||
|
There was a problem hiding this comment. 코드 가독성을 위해 들여쓰기 간격을 맞춰주세요! |
||
| #logo { | ||
| width: 150px; | ||
| } | ||
| a { | ||
| text-decoration: none; | ||
| color: inherit; | ||
| cursor: pointer; | ||
| } | ||
| /* 버튼 부분 */ | ||
| .button { | ||
|
There was a problem hiding this comment. 관련 있는 코드를 모아두어 보기가 좋네요! 👍 |
||
| background-color: #3692ff; | ||
| color: #ffffff; | ||
| display: inline-flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| cursor: pointer; | ||
| } | ||
| .button:hover { | ||
| background-color: #1967d6; | ||
| } | ||
|
|
||
| .button:focus { | ||
| background-color: #1251aa; | ||
| } | ||
|
|
||
| .button:disabled { | ||
| background-color: #9ca3af; | ||
| cursor: default; | ||
| pointer-events: none; | ||
| } | ||
|
|
||
| #loginbutton.button { | ||
| font-size: 16px; | ||
| font-weight: 600; | ||
| border-radius: 8px; | ||
| padding: 11.5px 23px; | ||
| } | ||
| /* 버튼 부분 */ | ||
| /* 헤더 부분 */ | ||
| /* 메인 부분 */ | ||
| /*섹션 부분*/ | ||
| /* 섹션 메인 베너 부분 */ | ||
| .banner { | ||
| background-color: #cfe5ff; | ||
| height: 540px; | ||
| display: flex; | ||
| align-items: center; | ||
| background-repeat: no-repeat; | ||
| background-position: 80% bottom; | ||
| background-size: 55%; | ||
| } | ||
|
|
||
| #mainbanner { | ||
| background-image: url("pandamain.png"); | ||
|
There was a problem hiding this comment.
|
||
| } | ||
| .goitem { | ||
| font-size: 20px; | ||
| font-weight: 700; | ||
| border-radius: 999px; | ||
| padding: 16px 124px; | ||
| } | ||
|
|
||
| .banner .goitem { | ||
| margin-top: 32px; | ||
| } | ||
| /* 섹션 메인 베너 부분 */ | ||
| /* 섹션 홈로그 영역 */ | ||
| #hotitem { | ||
| padding-bottom: 138px; | ||
| } | ||
|
|
||
| .bannerwrap { | ||
| max-width: 1200px; | ||
|
There was a problem hiding this comment. 요구 사항을 확인해주세요! 크기게 맞지 않습니다 :) |
||
| margin: 0 auto; | ||
| width: 100%; | ||
| } | ||
| .itempack { | ||
| padding: 138px 0; | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 5%; | ||
|
There was a problem hiding this comment.
|
||
| } | ||
|
|
||
| .homelogo { | ||
| width: 50%; | ||
| } | ||
|
|
||
| .itemcheck { | ||
| flex: 1; | ||
| } | ||
|
|
||
| .itemtag { | ||
| color: #3692ff; | ||
| font-size: 18px; | ||
| line-height: 25px; | ||
| font-weight: 700; | ||
| margin-bottom: 12px; | ||
| } | ||
|
|
||
| .besthotitem { | ||
| font-size: 24px; | ||
| font-weight: 500; | ||
| line-height: 120%; | ||
| letter-spacing: 0.08em; | ||
| margin-top: 24px; | ||
| } | ||
| /* 섹션 홈로그 영역 */ | ||
| /*섹션 부분*/ | ||
| /* 바텀 배너 부분*/ | ||
| #bottomBanner { | ||
| background-image: url("lastpanda.png") | ||
| } | ||
| /* 바텀 배너 부분*/ | ||
| /* 메인 부분 */ | ||
| /*푸터 부분*/ | ||
| footer { | ||
| background-color: #111827; | ||
| color: #9ca3af; | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| padding: 32px 200px 108px 200px; | ||
| font-size: 16px; | ||
| } | ||
|
|
||
| #footeMenu { | ||
| display: flex; | ||
| gap: 30px; | ||
| color: #e5e7eb; | ||
| } | ||
|
|
||
| #Media { | ||
| display: flex; | ||
| gap: 12px; | ||
| } | ||
| /*푸터 부분*/ | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Document</title> | ||
| </head> | ||
| <body> | ||
|
|
||
| </body> | ||
| </html> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
|
There was a problem hiding this comment.
|
||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>판다마켓</title> | ||
| <link rel="stylesheet" href="SMstyle.css"> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <a herf="homepage.html"> | ||
| <img src="logo1.png" id="logo"> | ||
|
There was a problem hiding this comment. img를 쓰실 때 alt를 넣어주시는 것이 접근성에 좋습니다! |
||
| </a> | ||
| <a herf="login.html" class="button"id="loginbutton" >로그인</a> | ||
| </header> | ||
| <main> | ||
| <section id="mainbanner" class="banner"> | ||
| <div class="bannerwrap"> | ||
| <h1> | ||
| 일상의 모든 물건을<br> | ||
| 거래해 보세요 | ||
| </h1> | ||
| <a href="items.html" class="goitem button">구경하러 가기</a> | ||
| </div> | ||
| </section> | ||
| <section id="hotitem" class="bannerwrap"> | ||
|
There was a problem hiding this comment.
|
||
| <div class="itempack"> | ||
| <img src="homelogo1.png" class="homelogo"> | ||
| <div class="itemcheck"> | ||
| <h2 class="itemtag"> | ||
| Hot item | ||
| </h2> | ||
| <h1> | ||
| 인기상품을<br> | ||
| 확인해 보세요 | ||
| </h1> | ||
| <p class="besthotitem"> | ||
| 가장 HOT한 중고거래 물품을<br> | ||
| 판다마켓에서 확인해 보세요 | ||
| </p> | ||
| </div> | ||
| </div> | ||
| <div class="itempack"> | ||
| <div class="itemcheck"> | ||
| <h2 class="itemtag"> | ||
| Search | ||
| </h2> | ||
| <h1>구매를 원하는<br> | ||
|
There was a problem hiding this comment. h tag 는 계층 구조로 사용하시는 것이 접근성에 좋습니다! h1은 페이지에 하나가 되어야합니다 :) https://developer.mozilla.org/ko/docs/Web/HTML/Element/Heading_Elements#사용_일람 |
||
| 상품을 검색하세요 | ||
| </h1> | ||
| <p class="besthotitem"> | ||
| 구매하고 싶은 물품은 검색해서<br> | ||
| 쉽게 찾아보세요 | ||
| </p> | ||
| </div> | ||
| <img src="homelogo2.png" class="homelogo"> | ||
| </div> | ||
| <div class="itempack"> | ||
| <img src="homelogo3.png" class="homelogo"> | ||
| <div class="itemcheck"> | ||
| <h2 class="itemtag"> | ||
| Register | ||
| </h2> | ||
| <h1> | ||
| 판매를 원하는<br> | ||
| 상품을 등록하세요 | ||
| </h1> | ||
| <p class="besthotitem"> | ||
| 어떤 물건이든 판매하고 싶은 상품을<br> | ||
| 쉽게 등록하세요. | ||
| </p> | ||
| </div> | ||
| </div> | ||
| </section> | ||
| <section id="bottomBanner" class="banner"> | ||
|
There was a problem hiding this comment. 어떤 곳에서는 카멜케이스를 쓰고 있고 어떤 곳에서는 전부 소문자로 쓰이고 있는데, 한 가지 케이스로 통일해주세요 :) 참참고로, html, css는 보통 케밥 케이스를 많이 씁니다! |
||
| <div class="bannerwrap"> | ||
| <h1> | ||
| 믿을 수있는<br> | ||
| 판다마켓 중고거래 | ||
| </h1> | ||
| </div> | ||
| </section> | ||
| </main> | ||
| <footer> | ||
| <div> | ||
| @codeit - 2024 | ||
| </div> | ||
| <div id="footeMenu"> | ||
| <a href="Faq.html"> | ||
| FAQ | ||
| </a> | ||
| </div> | ||
| <div id="media"> | ||
| <a href="https://www.facebook.com/"> | ||
| <img src="ic_facebook.png"> | ||
| </a> | ||
| <a href="https://twitter.com/"> | ||
| <img src="ic_twitter.png"> | ||
| </a> | ||
| <a href="https://www.youtube.com/"> | ||
| <img src="ic_youtube.png"> | ||
| </a> | ||
| <a href="https://www.instagram.com/"> | ||
| <img src="ic_instagram.png"> | ||
| </a> | ||
| </div> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Document</title> | ||
| </head> | ||
| <body> | ||
|
|
||
| </body> | ||
| </html> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Document</title> | ||
| </head> | ||
| <body> | ||
|
|
||
| </body> | ||
| </html> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지금은 css 파일이 하나라 괜찮지만, 태그에 직접 스타일을 주게 되면 페이지 전체에 영향을 주기 때문에 지양하시는 것이 좋습니다!! 되도록 클래스를 이용해주세요~ :)