Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightowlzz
requested review from
bootcampCodeit
and removed request for
bootcampCodeit
Siihyun
approved these changes
Feb 26, 2024
|
|
||
| /* 기타 */ | ||
| html { font-size: 16px; } | ||
| .hide{ position: absolute;clip: rect(0 0 0 0); width: 1px; height: 1px; margin: -1px; overflow: hidden;} |
There was a problem hiding this comment.
css를 한줄에 작성하는건 가독성이 떨어집니다.
혹시 번들 사이즈를 고려하신 코딩이라면, 실제 빌드 환경에서는 번들러(webpack, vite등)의 minify option을 통해 최소한의 크기로 만들 수 있으니 작업하실때는 속성별로 한 줄에 나누어 작업해주세요.
ex)
.hide {
position: absolute;
clip: rect(0 0 0 0);
width: 1px;
height: 1px;
margin: -1px;
overflow: hidden;
}
|
|
||
|
|
||
| // 비밀번호가 일치하는지 확인하는 기능 | ||
| function validatePasswordsMatch(passWrod1, passWrod2) { |
There was a problem hiding this comment.
password, confirmPassword로 수정되어도 좋겠네요.
Comment on lines
+18
to
+27
| /* 타이틀 사이즈 pc 기준 - 48,64*/ | ||
| --title-size-l: 4rem; | ||
| --title-size-m: 3rem; | ||
|
|
||
| /* 폰트 사이트- 13,14,16,18,20 */ | ||
| --font-size-l: 1.25rem; | ||
| --font-size-lm: 1.125rem; | ||
| --font-size-m: 1rem; | ||
| --font-size-sm: 0.875rem; | ||
| --font-size-s: 0.815rem; |
| <link rel="stylesheet" href="css/common/header.css"> | ||
| <link rel="stylesheet" href="css/common/footer.css"> | ||
| <link rel="stylesheet" href="css/page/join.css"> | ||
| <script defer src="js/style.js"></script> |
There was a problem hiding this comment.
style 수정뿐만 아니라 비밀번호 유효성 검사와 같은 비즈니스 로직을 담고있는 파일이라, style.js 보다는 조금 더 파일 의미를 담는 파일명으로 수정되면 좋겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
main 페이지 반응형 작업
로그인 페이지 작업
회원가입 페이지 작업
스크린샷
멘토에게