Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay-WKJun
reviewed
May 10, 2024
| @@ -9,14 +10,27 @@ import EditableStarButton from "./EditableStarButton"; | |||
| import KebabButton from "./KebabButton"; | |||
| import { useLocation } from "react-router-dom"; | |||
|
|
|||
| function Card({ card }) { | |||
| interface FolderCardData { | |||
There was a problem hiding this comment.
Card 컴포넌트의 Prop에 대한 type인데 CardPropType 정도로 표현하면 더 직관적이지 않을까요?
|
|
||
| function KebabList({ url, setDisplay }) { | ||
| const { openModal, setModalType, setCardUrl } = useContext(ModalContext); | ||
| interface KebabListInterface { |
There was a problem hiding this comment.
변수명에 변수 타입이 들어가는 것이 안좋듯이, type과 interface도 마찬가지입니다.
Comment on lines
+14
to
+25
| interface UserFolderCardDataList { | ||
| data: { | ||
| id: number; | ||
| createdAt: string; | ||
| description?: string; | ||
| folderId?: number; | ||
| title?: string; | ||
| updatedAt?: string; | ||
| url: string; | ||
| imageSource?: string; | ||
| }; | ||
| } |
There was a problem hiding this comment.
바로 위에 선언한 CardListData를 재활용하는 것이 좋습니다.
TS의 & 를 잘 이용해보세요.
| import React from "react"; | ||
| import "./Button.css"; | ||
|
|
||
| interface buttonData { |
There was a problem hiding this comment.
타입의 이름들은 파스칼케이스로 작성해주시는 편이 좋습니다.
| function FolderAddModal({ modalTypeLabels, modalType, cardUrl, folderTabDataList }) { | ||
| const [activeId, setActiveId] = useState(null); | ||
| interface UserFolderdataList { | ||
| data: { |
There was a problem hiding this comment.
굳이 data라는 depth가 필요할까요?
이 또한, 필요할 때마다 다른 내용을 보면서 선언하거나 하나의 정리된 타입을 사용하지 않아서 발생하는 이상한 타입의 전형입니다.
타입을 더 큰 범위에서 정리해보는 것이 좋을 것 같습니다.
Comment on lines
+8
to
+25
| interface FolderData { | ||
| id: number; | ||
| name: string; | ||
| owner: { | ||
| id: number; | ||
| name: string; | ||
| profileImageSource: string; | ||
| }; | ||
| links: { | ||
| id: number; | ||
| createdAt: string; | ||
| url: string; | ||
| title: string; | ||
| description: string; | ||
| imageSource?: string; | ||
| }[]; | ||
| count: number; | ||
| } |
There was a problem hiding this comment.
몇번이나 봤던 interface가 계속 나오는거 같네요.
하나의 type으로 관리해보는 것이 좋을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
주요 변경사항
멘토에게