Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[김서영] Sprint1 #36

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions faq.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>FAQ</title>
</head>
<body>
<h1>FAQ</h1>
</body>
</html>
Binary file added img/Img_home_01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ic_facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added img/logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
122 changes: 122 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
<!DOCTYPE html>
<html lang="en">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lang="ko" 속성을 사용해보는건 어떨까요?

Suggested change
<html lang="en">
<html lang="ko">

lang 속성은 Search bot이 탐색할 때 해당 문서가 어떠한 언어로 작성되어있는지 파악할 때 사용될 수 있습니다.
따라서 적절한 lang을 설정하시는걸 권장드립니다. 😊

lang의 기본 값은 '알 수 없음'입니다. 따라서 적절한 값의 lang 속성을 꼭 꼭 ! 설정해주시는걸 권장합니다 !
lang에 대해서 자세히 보기

SEO 마케팅 관련 기사

tl;dr

lang 속성은 다음을 포함하여 다양한 목적으로 사용됩니다.

  • 검색 엔진은 lang 속성을 사용하여 올바른 언어로 웹 페이지를 색인화합니다. 이를 통해 특정 언어로 검색하는 사용자에게 더 관련성이 높은 결과를 반환할 수 있습니다.
  • 화면 판독기는 lang 속성을 사용하여 언어 프로필을 전환하여 올바른 악센트와 발음을 제공합니다. 이는 시각 장애가 있는 사용자가 선호하는 언어로 웹 콘텐츠에 액세스하는 데 도움이 됩니다.
  • lang 속성을 사용하여 번역해야 하는 텍스트를 식별할 수 있습니다. 이는 다국어 웹사이트를 만들거나 사용자 생성 콘텐츠를 번역하는 데 유용할 수 있습니다.

<html> 요소 자체를 포함하여 텍스트 콘텐츠를 포함하는 모든 HTML 요소에 lang 속성을 지정해야 한다는 점에 유의하는 것이 중요합니다. 이렇게 하면 전체 웹페이지의 언어가 올바르게 식별됩니다.
원문 보기

<head>
<meta charset="UTF-8" />
<link rel="stylesheet" href="style.css" />
<title>판다마켓</title>
<!-- 글꼴 CDN -->
<link
rel="stylesheet"
type="text/css"
href="https://cdn.jsdelivr.net/gh/orioncactus/pretendard/dist/web/static/pretendard.css"
/>
</head>
<body>
<!-- header 시작 -->
<header>
<div onclick="location.href = '/'">
<img class="logo" src="img/logo.png" alt="판다마켓 로고" />
</div>
<div class="login-btn-container">
<a href="signin.html" class="login-btn">로그인</a>
</div>
</header>
<!-- header 끝 -->
<!-- 베너 시작 -->
<div class="home-top-container">
<div class="home-top">
<p class="home-top-title">일상의 모든 물건을<br />거래해 보세요</p>
<div class="home-top-btn">
<a href="items.html" class="items-btn">구경하러 가기</a>
</div>
</div>
<img
src="img/Img_home_top.png"
alt="상단 베너 판다 이미지"
class="home-top-img"
/>
Comment on lines +33 to +37
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt를 꼼꼼히 작성해주셨군요 ! 👍

alt는 스크린 리더 사용자에 대한 보조 텍스트가 될 수 있으므로 "어떠한 이미지 인지"를 작성해주는 것이 좋아요 !

alt의 목적

  • 인터넷 연결이 끊겼을 때 대체되는 이미지
  • 스크린 리더 사용자를 위한 대체 텍스트
  • 이미지를 볼 수 없는 환경에서 이미지를 대체하기 위한 텍스트
    등 목적을 알게 된다면 alt를 어떻게 사용하시면 될지 알 수 있을 것 같아요.

다음은 하버드 에듀케이션에서 제안하는 alt 규칙입니다:

tl;dr

  • Write Good Alt Text
  • Add alt text all non-decorative images.
  • Keep it short and descriptive, like a tweet.
  • Don’t include “image of” or “photo of”.
  • Leave alt text blank if the image is purely decorative
  • It's not necessary to add text in the Title field.

원문 보기

</div>
<!-- 베너 끝 -->
<!-- 메인 시작 -->
<main>
<!-- 1 -->
<section>
<img src="img/Img_home_01.png" href="메인 이미지1" class="main-img" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오타가 있는 것 같아요 😊

Suggested change
<img src="img/Img_home_01.png" href="메인 이미지1" class="main-img" />
<img src="img/Img_home_01.png" alt="메인 이미지1" class="main-img" />

<div class="main-container">
<p class="main-topic">Hot Item</p>
<p class="main-title">
인기 상품을<br />
확인해 보세요
</p>
<p class="main-content">
가장 HOT한 중고거래 물품을<br />
판다 마켓에서 확인해 보세요
</p>
</div>
</section>
<!-- 2 -->
<section class="right">
<!-- <img src="img/Img_home_02.png" href="메인 이미지2" class="main-img" /> -->
<div class="main-container-right">
<p class="main-topic">Search</p>
<p class="main-title">
구매를 원하는<br />
상품을 검색하세요
</p>
<p class="main-content">
구매하고 싶은 물품은 검색해서<br />
쉽게 찾아보세요
</p>
</div>
<img src="img/Img_home_02.png" href="메인 이미지2" class="main-img" />
</section>
<!-- 3 -->
<section>
<img src="img/Img_home_03.png" href="메인 이미지3" class="main-img" />
<div class="main-container">
<p class="main-topic">Register</p>
<p class="main-title">
판매를 원하는<br />
상품을 등록하세요
</p>
<p class="main-content">
어떤 물건이든 판매하고 싶은 상품을<br />
쉽게 등록하세요
</p>
</div>
</section>
</main>
<!-- 메인 끝 -->
<div class="home-bottom-container">
<p class="home-bottom">믿을 수 있는<br />판다마켓 중고거래</p>
<img
class="home-bottom-img"
src="img/Img_home_bottom.png"
alt="판다 중고거래 이미지"
/>
</div>
<footer>
<div class="footer-container">
<p class="footer-codeit">@codeit - 2024</p>
<div class="footer-center">
<a href="/privacy.html" class="footer-privacy">Privacy Policy</a>
<a href="/faq.html" class="footer-faq">FAQ</a>
</div>
<div class="footer-ic">
<a href="https://www.facebook.com" target="_blank"
><img src="img/ic_facebook.png" alt="페이스북"
/></a>
<a href="https://twitter.com" target="_blank"
><img src="img/ic_twitter.png" alt="트위터"
/></a>
<a href="https://www.youtube.com" target="_blank"
><img src="img/ic_youtube.png" alt="유튜브"
/></a>
<a href="https://www.instagram.com" target="_blank">
<img src="img/ic_instagram.png" alt="인스타그램"
/></a>
</div>
</div>
</footer>
</body>
</html>
11 changes: 11 additions & 0 deletions items.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Items</title>
</head>
<body>
<h1>Items</h1>
</body>
</html>
11 changes: 11 additions & 0 deletions privacy.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Privacy</title>
</head>
<body>
<h1>Privacy</h1>
</body>
</html>
11 changes: 11 additions & 0 deletions signin.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>signin</title>
</head>
<body>
<h1>signin</h1>
</body>
</html>
Loading
Loading