Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[이도요] Sprint1 #37

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added images/content2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/content3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/insta.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/login.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/panda.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/panda2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
102 changes: 102 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>판다마켓</title>
<link rel="stylesheet" as="style" crossorigin href="https://cdn.jsdelivr.net/gh/orioncactus/pretendard@v1.3.6/dist/web/static/pretendard.css">
<link rel="stylesheet" href="style.css">
</head>
<body>
<header class="gnb">
<a href="/">
<img class="logo" src= "images/logo.png">
</a>
<a href="/signin" class="login">로그인</a>
</header>
<section class="main-banner">
<div class="banner">
<h2 class="banner-text">
일상의 모든 물건을<br>
거래해 보세요.
</h2>
<a href="/items" target="_blank" class="banner-link">구경하러 가기</a>
</div>
<img class="banner-panda" src="images/panda.png" width="996px" height="447px">
</section>
<section class="section1">
<img class="content1" src="images/content1.png" width="588px" height="444px">
<div class="content-text">
<span>Hot item</span>
<h2>
인기상품을<br>
확인해 보세요
</h2>
<p>
가장 HOT한 중고거래 물품을<br>
판다 마켓에서 확인해 보세요
</h3>
Comment on lines +35 to +38
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이부분 전부 태그가 잘못 닫혀있네요

</div>
</section>
<section class="section2">
<div class="content-text">
<span>Search item</span>
<h2>
구매를 원하는<br>
상품을 검색하세요
</h2>
<p>
구매하고 싶은 물품은 검색해서<br>
쉽게 찾아보세요
</h3>
</div>
<img class="content3" src="images/content2.png" width="588px" height="444px">
</section>
<section class="section1">
<img class="content3" src="images/content3.png" width="588px" height="444px">
<div class="content-text">
<span>Register</span>
<h2>
판매를 원하는<br>
상품을 등록하세요
</h2>
<p>
어떤 물건이든 판매하고 싶은 상품을<br>
쉽게 등록하세요
</h3>
</div>
</section>
<section class="main-banner">
<div class="banner">
<h2 class="banner-text">
믿을 수 있는<br>
판다마켓 중고거래
</h2>
</div>
<img class="bottom-banner-panda" src="images/panda2.png" width="996px" height="540px">
</section>
<footer class="footer">
<div class="bottom-banner">
<p class="codeit"> @codeit-2024 </p>
<div class="faq">
<a href="/privacy" class="faq">Privacy Policy</a>
<a href="/faq" class="faq">FAQ</a>
</div>
<div class="sns">
<a href="#" target="_blank">
<img src="images/facebook.png">
</a>
<a href="#" target="_blank">
<img src="images/x.png">
</a>
<a href="#" target="_blank">
<img src="images/youtube.png">
</a>
<a href="#" target="_blank">
<img src="images/insta.png">
</a>
</div>
</div>
</footer>
</body>
</html>
134 changes: 134 additions & 0 deletions style.css
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

당장 큰 문제는 없긴하지만
section, content등 겹치기 쉬운 형태의 class name들이 많은 것 같습니다.
class name 충돌을 피하기위해 최대한 특화된 이름으로 지어주는게 좋습니다.
부모의 class name을 붙여서 footer_bottom-banner 이런식으로 지어주는것도 방법입니다.

추가로 gnb나 logo같은 한개만 존재하는 요소의 경우 id를 넣어주면 겹치는 실수를 어느정도 방지할 수 있습니다.

Original file line number Diff line number Diff line change
@@ -0,0 +1,134 @@

html {
font-family: Pretendard, sans-serif;
}

body{
margin:0;
}

.gnb {
display: flex;
justify-content: space-between;
align-items: center;
margin:0 200px;
}
.gnb .logo {
width: 153px;
height: 51px;
}
.gnb .login {
border-radius: 8px;
background-color: #3692FF;
color: #ffffff;
font-size: 16px;
font-weight: 600;
padding:12px 20px 12px 20px;
gap:10px;
text-decoration: none;
cursor: pointer;
}

.main-banner {
background-color: #CFE5FF;
width: 100%;
height: 540px;
display: flex;
justify-content: center;
align-items: center;
}
.banner {
display: flex;
flex-direction: column;
}
.banner-panda {
margin-top:93px;
}
.banner-text {
font-size: 40px;
font-weight: 700;
width: 355px;
}
.banner-link {
border-radius: 40px;
background-color: #3692FF;
font-size: 20px;
font-weight: 600;
color: #ffffff;
text-decoration: none;
padding:16px;
gap: 32px;
text-align: center;
cursor: pointer;
}

.section1 {
width: 1200px;
display: flex;
align-items: center;
gap: 64px;
margin-top:138px;
margin-left:360px;
margin-bottom:138px;
}
.section2 {
width:1200px;
display: flex;
align-items: center;
gap:64px;
margin-top: 138px;
margin-left: 591px;
text-align: right;
}

.content-text span {
color:#3692FF;
font-size: 18px;
font-weight: 700;
}
.content-text h2 {
color: #374151;
font-size: 40px;
font-weight: 700;
}
.content-text p {
color: #374151;
font-size: 24px;
font-weight: 500;
}

.footer {
width: auto;
height: 160px;
background-color: #111827;
padding:32px 200px 32px 200px;
}
.bottom-banner {
display: flex;
justify-content: space-between;
align-items: center;
gap:30px;
}
.bottom-banner .codeit {
color: #9CA3AF;
font-size: 16px;
font-weight: 400;
text-align: center;
}
.bottom-banner .faq {
color: #E5E7EB;
font-size: 16px;
font-weight: 400;
text-align: center;
text-decoration: none;
display: flex;
gap:30px;
cursor: pointer;
}
.bottom-banner .sns {
display: flex;
gap:12px;
width: 20px;
height: 20px;
cursor: pointer;
}
Loading