[함예진] Sprint1 #61
There are no files selected for viewing
Empty file.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,99 @@ | ||||||||
| <!DOCTYPE html> | ||||||||
| <head> | ||||||||
|
There was a problem hiding this comment.
|
||||||||
| <head> | |
| <html> | |
| <head> |
There was a problem hiding this comment.
alt를 작성해볼까요?
alt는 스크린 리더 사용자에 대한 보조 텍스트가 될 수 있으므로 "어떠한 이미지 인지"를 작성해주는 것이 좋아요 !
꼭 작성하시는걸 �제안드립니다 !
alt의 목적
- 인터넷 연결이 끊겼을 때 대체되는 이미지
- 스크린 리더 사용자를 위한 대체 텍스트
- 이미지를 볼 수 없는 환경에서 이미지를 대체하기 위한 텍스트
등 목적을 알게 된다면 alt를 어떻게 사용하시면 될지 알 수 있을 것 같아요.
다음은 하버드 에듀케이션에서 제안하는 alt 규칙입니다:
tl;dr
- Write Good Alt Text
- Add alt text all non-decorative images.
- Keep it short and descriptive, like a tweet.
- Don’t include “image of” or “photo of”.
- Leave alt text blank if the image is purely decorative
- It's not necessary to add text in the Title field.
Empty file.
Empty file.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| * { | ||
| margin: 0; | ||
| padding: 0; | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| header { | ||
| width: 100%; | ||
| height: 70px; | ||
| padding: 0 200px; | ||
| background-color: #ffffff; | ||
| display: flex; | ||
| align-items: center; | ||
| border-bottom: 1px solid #dfdfdf; | ||
| justify-content: space-between; | ||
| } | ||
|
|
||
| .button { | ||
| background-color: #3692ff; | ||
| color: #ffffff; | ||
| font-size: 20px; | ||
| font-weight: 700; | ||
| border-radius: 999px; | ||
| padding: 16px 126px; | ||
| display: inline-flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| } | ||
|
|
||
| .button:hover { | ||
| background-color: #1967d6; | ||
| } | ||
|
|
||
| #sign-button { | ||
|
There was a problem hiding this comment. 네이밍을 일관적으로 작성하시는게 어떨까요?파스칼 케이스, �케밥 케이스, 카멜케이스 등 여러가지 섞여있는 것 같아요. 네이밍을 일관적으로 작성하시는게 어떨까요 ? |
||
| border-radius: 8px; | ||
| padding: 14.5px 43px; | ||
| font-size: 16px; | ||
| font-weight: 600; | ||
| } | ||
|
|
||
| body { | ||
| color: #374151; | ||
| font-family: "Pretendard", sans-serif; | ||
| } | ||
|
|
||
| .banner { | ||
| background-color: #cfe5ff; | ||
| height: 540px; | ||
| display: flex; | ||
| background-size: 55%; | ||
| align-items: center; | ||
| background-position: 80% bottom; | ||
| margin-top: 32px; | ||
| } | ||
|
|
||
| .wrapper { | ||
| max-width: 1200px; | ||
| margin: 0 auto; | ||
| width: 100%; | ||
| } | ||
|
|
||
| #features { | ||
| padding-bottom: 138px; | ||
| } | ||
|
|
||
| .feature { | ||
| padding: 138px 0; | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 5%; | ||
| } | ||
|
|
||
| .feature-content { | ||
| flex: 1; | ||
| } | ||
|
|
||
| .feature-name { | ||
| color: #3692ff; | ||
| margin-bottom: 12px; | ||
| font-size: 18px; | ||
| font-weight: 700; | ||
| line-height: 25px; | ||
| } | ||
|
|
||
| .feature-explanation { | ||
| margin-top: 24px; | ||
| font-size: 24px; | ||
| line-height: 120%; | ||
| font-weight: 500; | ||
| } | ||
|
|
||
| #top { | ||
| background-image: url("images/hero-image.png"); | ||
| background-repeat: no-repeat; | ||
| background-position: center; | ||
| background-size: cover; | ||
| } | ||
|
|
||
| a { | ||
| text-decoration: none; | ||
| color: inherit; | ||
| } | ||
|
Comment on lines
+99
to
+102
There was a problem hiding this comment.
|
||
|
|
||
| h1 { | ||
| font-size: 40px; | ||
| font-weight: 700; | ||
| line-height: 56px; | ||
| } | ||
|
|
||
| #bottom { | ||
| background-image: url("images/bottom-banner-image.png"); | ||
| background-repeat: no-repeat; | ||
| background-position: center; | ||
| background-size: cover; | ||
| } | ||
|
|
||
| footer { | ||
| padding: 32px 200px 108px 200px; | ||
| font-size: 16px; | ||
| background-color: #111827; | ||
| color: #9ca3af; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| } | ||
|
|
||
| #Menu { | ||
| display: flex; | ||
| gap: 30px; | ||
| color: #e5e7eb; | ||
| } | ||
|
|
||
| #social { | ||
| display: flex; | ||
| gap: 12px; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
파일명 잘 지었네요 ! 딱 봐도 어떤 이미지인지 알겠어요 👍