Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 스타일 수정, 컴포넌트 분리 등
Il9
reviewed
Jun 8, 2024
pages/addboard/index.tsx
Outdated
Comment on lines
35
to
50
| const formData = new FormData(); | ||
| formData.append("content", content); | ||
| formData.append("title", title); | ||
| if (image) { | ||
| formData.append("image", image); | ||
| } | ||
|
|
||
| const res = await axiosFetch({ | ||
| method: 'POST', | ||
| url: "/articles", | ||
| data: formData, | ||
| headers: { | ||
| Authorization: `Bearer ${ACCESS_TOKEN}` | ||
| }, | ||
| // withCredentials: true, | ||
| }); |
There was a problem hiding this comment.
이런 api call들은 별도로 만들어서
api.createArticle 같은 형태로 인터페이스를 제공해주면 좋을 것 같습니다.
멘토링 때 말씀드린 것 처럼 역할군을 나누어서 로직을 분리하는 연습을 해보시는 걸 추천드립니다.
| import { axiosRequester } from "lib/axios"; | ||
| import { AxiosRequestConfig} from "axios"; | ||
|
|
||
| type AxiosFetch = <T>(options: AxiosRequestConfig<T>) => Promise<T | any>; |
There was a problem hiding this comment.
useAxiosFetch의 axiosFetch의 타입을 지정했는데, unknown 형식은 T 형식에 할당할 수 없다. 라고 뜹니다. 일단 반환값을 Promise<T | any>으로 임시방편해놓았는데, 어떻게 해야할지 모르겠습니다.
처음에 어떤식으로 선언하셨는지 모르겠지만, AxiosRequestConfig에서 unknown을 안받아줬다면
<T extends 어쩌고> 의 형식으로 제네릭으로 들어올 수 있는 타입을 제한시킬 수 있습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
상품 등록 페이지
상품 상세 페이지
주요 변경사항
스크린샷
멘토에게