Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyh0521
approved these changes
Jun 8, 2024
There was a problem hiding this comment.
.env 적용해주신 점 좋습니다. 다만, .env의 목적은 보안 목적으로 해당 변수들을 깃허브에 올리지 않기 위함이라서 .gitignore에 추가해주시고 올리시지 않아주시면 됩니다.
| @@ -7,15 +7,14 @@ function formatDate(value) { | |||
| } | |||
|
|
|||
| export default function ArticleList({ articles = [] }) { | |||
| console.log(articles.writer); | |||
| text-Decoration: none; | ||
| padding: 24px 23px; | ||
| color: #4b5563; | ||
| color: #4B5563; |
There was a problem hiding this comment.
color에 컬러 변수를 활용해보시는 것도 추천드립니다! 나중에 유지보수 할때, 색상이 변경되면, 컬러 변수의 값 하나만 변경하면 되기 때문입니다.
| const res = await axios.get(`/articles`); | ||
| console.log(res); | ||
| const router = useRouter(); | ||
| const { keyword } = router.query; |
There was a problem hiding this comment.
구조 분해 할당으로 query만 잘 꺼내서 사용해주셨네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게