Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaeSang1998
reviewed
Jul 8, 2024
|
|
||
| const query = `orderBy=${order}`; | ||
| const response = await fetch(`${BASE_URL}/products?${query}`); | ||
| const response = await fetch(`${BASE_URL}/products?${query}&page=${page}&pageSize=${pageSize}`); |
There was a problem hiding this comment.
query 가 길어질수록 URLSearchParams 등의 객체를 활용하는 습관을 들이면 좋습니다.
|
|
||
| export async function getComment(productSlug) { | ||
| const response = await fetch(`${BASE_URL}/products/${productSlug}/comments?limit=10`) |
There was a problem hiding this comment.
10 같은 limit 을 나타내는 상수는 물론 지금처럼 정적인 값으로 표현되어도 좋지만 LIMIT 등의 이름으로 상수화 해서 변수로 빼내어도 좋습니다.
| handleLoad(); | ||
| }, []); | ||
|
|
||
| const displayedItems = items.slice(0, 4); |
There was a problem hiding this comment.
4개만 보여준다고 하면 pageSize 도 함께 4였어도 괜찮지 않았을까요?
| @@ -26,6 +27,7 @@ function FileInput({ name, value, onChange }) { | |||
| if (!value) return; | |||
There was a problem hiding this comment.
useEffect 보다는 handleChange 에서 이루어졌다면 불필요한 effect 를 관리하지 않아도 될 것 같습니다!
| @@ -12,15 +12,15 @@ function AddItem() { | |||
| imgFile: null, | |||
| }); | |||
|
|
|||
| const [isButtonDisabled, SetisButtonDisabled] = useState(true); | |||
| const [isButtonDisabled, setIsButtonDisabled] = useState(true); | |||
|
|
|||
| useEffect(() => { | |||
| const allInput = values.introduction && values.price && values.productName && values.tag; | |||
| if (allInput) { | |||
There was a problem hiding this comment.
이 부분은 setIsButtonDisabled(!allInput) 으로 줄일 수 있겠네요
| const bestItems = item.sort((a, b) => b['favorite'] - a['favorite']); | ||
| useEffect(() => { | ||
| setTotalPages(Math.ceil(totalCount / pageSize)); | ||
| //Math.ceil(전체 컨텐츠 개수 / 한 페이지에 보여주고자 하는 컨텐츠의 개수) |
|
|
||
| const handleFavorite = () => setOrder('favorite'); | ||
| const SortedItems = item.sort((a, b) => b[order] - a[order]); |
There was a problem hiding this comment.
변수 소문자로 시작하게끔 꼭!! 해주세용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
상품
댓글
심화
주요 변경사항
스크린샷
멘토에게