Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyh0521
approved these changes
Aug 3, 2024
| @@ -16,7 +16,13 @@ const Button = styled.button` | |||
| } | |||
| `; | |||
|
|
|||
| function DeleteButton({ onClick, label }) { | |||
| function DeleteButton({ | |||
There was a problem hiding this comment.
props의 타입은 따로 선언해서 사용해주셔도 좋습니다.
| @@ -3,7 +3,18 @@ import "./PaginationBar.css"; | |||
| import { ReactComponent as LeftArrow } from "../../assets/images/icons/arrow_left.svg"; | |||
There was a problem hiding this comment.
alias path를 사용해보시는 것도 추천드립니다.
| @@ -59,6 +66,7 @@ function TagInput({ tags, onAddTag, onRemoveTag }) { | |||
| onChange={(e) => setInput(e.target.value)} | |||
| onKeyDown={onPressEnter} | |||
| placeholder="태그를 입력해 주세요" | |||
| isTextArea={undefined} | |||
There was a problem hiding this comment.
이런 경우는 isTextArea를 전달해주시지 않아도 됩니다.
There was a problem hiding this comment.
말씀해주신대로 삭제 처리 완료했습니다 !
Comment on lines
+28
to
+31
| const [name, setName] = useState<string>(""); | ||
| const [description, setDescription] = useState<string>(""); | ||
| const [price, setPrice] = useState<string>(""); | ||
| const [tags, setTags] = useState<string[]>([]); |
There was a problem hiding this comment.
관련 있는 상태들은 하나로 묶어서 객체로 관리하시는 방법도 있습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
주요 변경사항
스크린샷
멘토에게