-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[정원식] Sprint 8 #251
Merged
arthurkimdev
merged 7 commits into
codeit-bootcamp-frontend:React-정원식
from
wonsik3686:React-정원식-Sprint8
Aug 4, 2024
The head ref may contain hidden characters: "React-\uC815\uC6D0\uC2DD-Sprint8"
Merged
[정원식] Sprint 8 #251
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a5499ca
feat: 리액트 타입스크립트 프로젝트 생성
wonsik3686 264c75b
feat: 타입스크립트 초기 세팅
wonsik3686 c1d1545
파일 형식 변경
wonsik3686 3f025ad
privacy.tsx 추가
wonsik3686 821479b
typescript 전환 1
wonsik3686 fd0c517
typescript 전환 2
wonsik3686 ebaa3eb
typescript 전환 3
wonsik3686 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,29 @@ | ||
import { useEffect, useRef } from 'react'; | ||
|
||
import './Button.css'; | ||
|
||
interface ButtonProps { | ||
text?: string; | ||
onClick?: (e: React.MouseEvent<HTMLElement, MouseEvent>) => void; | ||
isDisabled?: boolean; | ||
iconFront?: React.ReactNode; | ||
iconBack?: React.ReactNode; | ||
customBorderRound?: any; | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
function Button({ | ||
text = '버튼', | ||
onClick = () => {}, | ||
isDisabled = false, | ||
iconFront, | ||
iconBack, | ||
customBorderRound, | ||
}) { | ||
const ref = useRef(); | ||
}: ButtonProps) { | ||
const ref = useRef<HTMLButtonElement>(null); | ||
|
||
useEffect(() => { | ||
ref.current.disabled = isDisabled ? true : false; | ||
if (ref.current) { | ||
ref.current.disabled = isDisabled; | ||
} | ||
}, [isDisabled]); | ||
|
||
return ( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기서 미리 정의한
type OrderType = 'recent' | 'favorite'
값을 가져오면 되겠네요!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아래 다른 값들도 처음 js -> ts 전환할때
any
로 시작하는 방법 좋구요. 👍 천천히 바꿔나가시면 됩니다.