Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlgns2223
reviewed
Aug 5, 2024
| } | ||
|
|
||
| const SignUpForm = () => { | ||
| const [value, setValue] = useState<InputValue>(INITIAL_VALUE); |
There was a problem hiding this comment.
InputValue가 코드상에 없는거보니까 리팩토링하면서 삭제하신것 같네요 ! 꼼꼼한 타입지정 잘 하셨습니다 !
|
|
||
|
|
||
| const usePasswordVisibility = () => { | ||
| const [icon, setIcon] = useState<string>(visibilityIcon); |
There was a problem hiding this comment.
아이콘을 상태에 넣을 수도 있군요. visibilityIcon이 string값으로 나오나요? 아마 상대경로 주소로 나오나보죠? 이 방법도 괜찮은 방법이 될 수도 있겠네요.
|
평소에 계속 타입스크립트로 스프린트 미션을 해오셔서 이번 스프린트 미션은 수월하셨겠네요 ! ㅎㅎㅎ |
|
평소에 잘 해오고 계셔서 현재 코드상으로는 타입스크립트 타입 관련 피드백이 드릴께 없어서 추후에 스프린트 미션이 계속 진행될때 더 많은 피드백을 드리겠습니다 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
주요 변경사항
스크린샷
멘토에게