Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub-actions [Fix] delete merged branch github action
- 다른 사람이 비정상적으로 올린 모든 이미지 url에 모두 대응해야하는 문제 임시적으로 해결함 - 이후에 컴포넌트 상에서 s3 주소만 필터링해서 띄우는 방향으로 수정할 예정
jyh0521
approved these changes
Aug 26, 2024
| } catch (error) { | ||
| console.log(error); | ||
| console.error(error); |
There was a problem hiding this comment.
console.error 반영해주신거 좋네요 :)
| @@ -27,7 +27,7 @@ const onErrorResponse = async (error: AxiosError | Error) => { | |||
|
|
|||
| switch (status) { | |||
| case 400: { | |||
| alert("입력한 정보가 올바르지 않습니다."); | |||
| alert(data.message); | |||
There was a problem hiding this comment.
시간이 되신다면 alert을 나타내는 ui를 반영해보시는 것도 추천드려요!
| @@ -11,7 +11,7 @@ const NAV_MENU_INFO = [ | |||
|
|
|||
| export default function GlobalNavBar() { | |||
| const { pathname } = useRouter(); | |||
| const isMain = pathname === "/" ? true : false; | |||
| const isMain = pathname === "/"; | |||
Comment on lines
+16
to
+17
| const currentTargetId = e.target.id; | ||
| const currentValue = e.target.value; |
There was a problem hiding this comment.
여기도 밑에서 사용하신 것 처럼 구조분해 할당을 활용하는 방법도 추천드립니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
사이트 배포 링크
요구사항
피그마 링크
기본 요구사항
체크리스트 (기본)
회원가입
로그인
메인
피드백 반영
추가 예정 사항
주요 변경사항
멘토에게