Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyh0521
approved these changes
Jun 10, 2024
| @@ -18,7 +18,7 @@ | |||
| <header> | |||
| <a href="/" | |||
| ><img | |||
| src="images/logo/panda-market-logo.png" | |||
| src="images/logo/panda-market-logo.svg" | |||
There was a problem hiding this comment.
이 부분을 svg로 사용하신 이유가 있을까요?
There was a problem hiding this comment.
혹시나 png일때랑 svg일때 로고 크기가 다를까 싶어서 svg로 테스트를 해봤는데, 차이점이 없는거같아서, png로 다시 바꾼다는걸 까먹었습니다...ㅎ
| alt="인기 상품" | ||
| width="50%" | ||
| /> | ||
| <img src="images/home/feature-hotitem.png" alt="인기 상품"/> |
There was a problem hiding this comment.
이미지 이름을 좀 더 명시적으로 작성해주신 점 좋습니다!
| @@ -33,7 +33,7 @@ | |||
| <div class="input-wrapper"> | |||
| <input id="password" name="password" type="password" placeholder="비밀번호를 입력해주세요"> | |||
| <button type="button" class="password-toggle-btn"> | |||
| <img src="/images/icons/invisible.svg" alt="비밀번호 숨김 아이콘"> | |||
| <img src="/images/icons/invisible.svg" alt="비밀번호 숨김 아이콘"/> | |||
| @@ -14,8 +14,10 @@ | |||
| --gray-200 : #E5E7EB; | |||
| --gray-100 : #F3F4F6; | |||
| --gray-50 : #F9FAFB; | |||
| --white : #ffffff; | |||
There was a problem hiding this comment.
색상 코드를 대문자로 사용하고 계시기 때문에 여기도 대문자로 통일해주시면 좋을 것 같습니다!
| @@ -24,18 +27,20 @@ | |||
| font-size: 16px; | |||
| font-weight: 600; | |||
| border-radius: 8px; | |||
| padding: 11.5px 23px; | |||
| padding: 12px 43px; | |||
| margin-top: 24px; | ||
| font-size: 16px; | ||
| line-height: 20px; | ||
| letter-spacing: 2px; |
There was a problem hiding this comment.
em을 px로 수정해주신 점 좋습니다! rem을 사용해보시는 것도 추천해드려요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
-Github에 PR(Pull Request)을 만들어서 미션을 제출합니다.
-피그마 디자인에 맞게 페이지를 만들어 주세요.
-React와 같은 UI 라이브러리를 사용하지 않고 진행합니다.
기본
렌딩 페이지
로그인, 회원가입 페이지 공통
심화
주요 변경사항
스크린샷
사이트 배포 링크
멘토에게