Update clUpdateMutableCommandsKHR to match new API #501
+664
−1,240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2024
Implementation change to prototype specification changes proposed in KhronosGroup/OpenCL-Docs#1041 Uses OpenCL changes from * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245 * KhronosGroup/OpenCL-CTS#1984
EwanC
force-pushed
the
update_using_array
branch
from
0db99fe
to
a91f218
Compare
bashbaug
pushed a commit
to KhronosGroup/OpenCL-CTS
that referenced
this pull request
Sep 6, 2024
CTS changes to reflect the spec changes merged in KhronosGroup/OpenCL-Docs#1045 and requires header updates from KhronosGroup/OpenCL-Headers#245 Tested using OCK implementation from codeplaysoftware/oneapi-construction-kit#501
EwanC
force-pushed
the
update_using_array
branch
from
32ede68
to
33ad6a6
Compare
EwanC
changed the title
coldav
approved these changes
Sep 24, 2024
hvdijk
reviewed
Sep 24, 2024
| CL_STRUCTURE_TYPE_MUTABLE_DISPATCH_CONFIG_KHR, | ||
| nullptr, | ||
| cl_mutable_dispatch_arg_khr args[] = {arg_0, arg_1, arg_2}; | ||
| cl_mutable_dispatch_config_khr dispatch_config{ |
There was a problem hiding this comment.
With the clang-tidy reports on the earlier version for variables that could be const, I am surprised that none are raised here. Could you check whether this really needs to be non-const, or whether the source file was skipped in the check?
hvdijk
reviewed
Sep 24, 2024
|
|
||
| for (const auto config_ptr : mutable_dispatch_configs) { | ||
| OCL_CHECK(config_ptr == nullptr, return CL_INVALID_VALUE); | ||
| const cl_mutable_dispatch_config_khr config = *config_ptr; |
There was a problem hiding this comment.
Originally, config was a reference, it should probably remain a reference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update cl_khr_command_buffer_mutable_dispatch implementation to reflect specification changes merged in KhronosGroup/OpenCL-Docs#1041
Reflects changes from upstream in:
Description of change
Updates our implementation from spec revision 0.9.1 of cl_khr_command_buffer_mutable_dispatch to revision 0.9.2 which made a breaking API change to
clUpdateMutableCommandsKHR().Checklist