Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(testutil): refactor registrytest #439

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

johnstcn
Copy link
Member

Refactors registrytest to a form that can be used by both envbuilder and terraform-provider-envbuilder.
Also fixes an issue with url.Parse incorrectly interpreting the scheme of host:port and attempting to push an image to Docker hub.

@johnstcn johnstcn self-assigned this Dec 19, 2024
@johnstcn johnstcn requested a review from mafredri December 19, 2024 17:53
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍🏻. Re: PR title either test or refactor would suit better as chore is for non-code related changes (although it's sometimes used "incorrectly" when something could be considered a chore).

@johnstcn johnstcn changed the title chore(testutil): refactor registrytest refactor(testutil): refactor registrytest Dec 19, 2024
@johnstcn johnstcn merged commit 2c0c991 into main Dec 19, 2024
4 checks passed
@johnstcn johnstcn deleted the cj/registrytest-refactor branch December 19, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants