feat: allow exiting on build failure with fallback #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for exiting envbuilder on build failure even when a `FALLBACK_IMAGE` is specified.
aaronlehmann
approved these changes
Oct 2, 2023
envbuilder.go
Outdated
| @@ -137,6 +137,12 @@ type Options struct { | |||
| // a Dockerfile is not found. | |||
There was a problem hiding this comment.
Should we update this to mention it also falls back on build failure unless ExitOnBuildFailure is set?
There was a problem hiding this comment.
Good point, will change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for exiting envbuilder on build failure even when a
FALLBACK_IMAGEis specified.