Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local features provided inside .devcontainer dir #96

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

aaronlehmann
Copy link
Collaborator

This allows features to be provided inside the .devcontainer directory rather than downloaded from a registry, matching the behavior of the official devcontainer tooling.

For example, Kubernetes tooling generates a devcontainer.json containing:

"features": {
    "ghcr.io/devcontainers/features/docker-outside-of-docker:1": {
        "enableNonRootDocker": "true",
        "moby": "true"
    },
    "ghcr.io/devcontainers/features/kubectl-helm-minikube:1": {},
    "./local-features/copy-kube-config": {}
},

cc @coryb

This allows features to be provided inside the .devcontainer directory
rather than downloaded from a registry, matching the behavior of the
official devcontainer tooling.

For example, Kubernetes tooling generates a devcontainer.json
containing:

    "features": {
        "ghcr.io/devcontainers/features/docker-outside-of-docker:1": {
            "enableNonRootDocker": "true",
            "moby": "true"
        },
        "ghcr.io/devcontainers/features/kubectl-helm-minikube:1": {},
        "./local-features/copy-kube-config": {}
    },
@aaronlehmann aaronlehmann requested a review from kylecarbs March 2, 2024 17:32
@aaronlehmann aaronlehmann changed the title Support local features provides inside .devcontainer dir Support local features provided inside .devcontainer dir Mar 2, 2024
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome add!

@aaronlehmann aaronlehmann merged commit 8af9ef8 into main Mar 3, 2024
1 check passed
@aaronlehmann aaronlehmann deleted the local-features branch March 3, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants