-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* chore: add http/pprof server over unix socket for debug * remove old pprof file without checking if it exists --------- Signed-off-by: Spike Curtis <spike@coder.com>
- Loading branch information
1 parent
9c250f1
commit 15ec603
Showing
3 changed files
with
49 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
//go:build !windows | ||
|
||
package main | ||
|
||
import ( | ||
"net" | ||
"net/http" | ||
"net/http/pprof" | ||
"os" | ||
) | ||
|
||
// servePprof starts an HTTP server running the pprof goroutine handler on a local unix domain socket. As described in | ||
// https://github.com/coder/coder/issues/14726 it appears this process is sometimes hanging, unable to exit cleanly, | ||
// and this prevents additional Coder builds that try to reinstall this provider. A goroutine dump should allow us to | ||
// determine what is hanging. | ||
// | ||
// This function is best-effort, and just returns early if we fail to set up the directory/listener. We don't want to | ||
// block the normal functioning of the provider. | ||
func servePprof() { | ||
// Coder runs terraform in a per-build subdirectory of the work directory. The per-build subdirectory uses a | ||
// generated name and is deleted at the end of a build, so we want to place our unix socket up one directory level | ||
// in the provisionerd work directory, so we can connect to it from provisionerd. | ||
err := os.Mkdir("../.coder", 0o700) | ||
if err != nil && !os.IsExist(err) { | ||
return | ||
} | ||
|
||
// remove the old file, if it exists. It's probably from the last run of the provider | ||
if err = os.Remove("../.coder/pprof"); err != nil && !os.IsNotExist(err) { | ||
return | ||
} | ||
l, err := net.Listen("unix", "../.coder/pprof") | ||
if err != nil { | ||
return | ||
} | ||
mux := http.NewServeMux() | ||
mux.Handle("/debug/pprof/goroutine", pprof.Handler("goroutine")) | ||
srv := http.Server{Handler: mux} | ||
go srv.Serve(l) | ||
// We just leave the server and domain socket up forever. Go programs exit when the `main()` function returns, so | ||
// this won't block exiting, and it ensures the pprof server stays up for the entire lifetime of the provider. | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
//go:build windows | ||
|
||
package main | ||
|
||
// servePprof is not supported on Windows | ||
func servePprof() {} |