Rails 6 support #30
Merged
Rails 6 support #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow upgrading to Ruby 3. Only define lower compatibility bound from now on to ease future updates REDMINE-19438
Add paths to both `autoload_paths` and `eager_load_paths`. `eager_load_paths` is required to have paths covered by `zeitwerk:check`. Ignore root file in lib which does not follow Zeitwerk conventions, but is required for Bundler to be able to require the gem. For Rails < 6, we cannot add `lib` to the `eager_load_paths` since Resque eager loads [1], which then evaluates the engine class a second time. This time `autoload_paths` is already frozen, resulting in an error. REDMINE-19438 [1] https://github.com/resque/resque/blob/v1.27.4/lib/resque/tasks.rb#L45
The reusable workflow now runs specs against experimental Rails versions which require Pageflow to be installed from a git source. REDMINE-19438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-19438