Reorder chapters mode #2150
Merged
Reorder chapters mode #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dragging large chapters is hard. REDMINE-20837
Less buggy when it comes to sorting items within a scrolling container. SortableJS triggers callbacks in different order: `onRemove` is invoked after `onAdd`. Since removing a model from a `ForeignKeySubsetCollection` resets the parent reference, we have to make sure to first remove and than add. Use the fact that - after `onAdd` - `onSort` is called on both sortables when moving an item and use it instead of `onRemove`. SortableJS leaves the dragged element in place and only applies a CSS class. Use this to simplify the placeholder setup. REDMIME-20837
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-20837