refactor(trackedfutures): remove return of future from tracked futures api #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emizzle
force-pushed
the
refactor/tracked-futures-api
branch
from
6ea9894 to
09770b9
Compare
benbierens
approved these changes
Dec 17, 2024
…s api - cleans up all instances of `.track` to use the `module.trackedfutures.track(future)` procedure, for better readability - removes the `track` override that is no longer used in the codebase
emizzle
force-pushed
the
refactor/tracked-futures-api
branch
from
09770b9 to
ba3ef7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.trackto use themodule.trackedfutures.track(future)procedure, for better readabilitytrackoverride that is no longer used in the codebaseNote: based on #1045.