Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eesha #222

Merged
merged 6 commits into from
Oct 1, 2020
Merged

Eesha #222

merged 6 commits into from
Oct 1, 2020

Conversation

eeshashetty
Copy link
Contributor

Description

I have added a new image processing script for Perspective Transform.

Make sure you have:

  • Visited http://join.codezoned.com/
  • Starred ScriptsDump!
  • Referred the issue number in the fixes title below.
  • Made a PR in Join_codezoned.
  • Joined our discord server.

Fixes #97

Type of change

Please delete options that are not relevant.

  • New Script

Copy link
Member

@master-fury master-fury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Can you please improve the readme? Try to add the following 1. weather the coordinates are respect to page or not. 2. Display height and width of the box. This will add flexibility and more people will be able to use this.

@eeshashetty
Copy link
Contributor Author

Updated the changes.

  • README.md explains how perspective transform works
  • The py script now prints dimensions of the new cropped area into the terminal

@master-fury
Copy link
Member

Nice Work! Keeping pushing more interesting and insightful scripts. 😄

@master-fury master-fury merged commit 9b145dd into codezoned:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some more Image processing scripts are required. #Hacktoberfest
2 participants