fix(test): run core lightning with the plugin directly #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for coffee-docs canceled.
|
Inside the CI we noted that the tests over the plugin get stuck and my suspection is that we had some problem to run the plugin with the `lightning-cli plugin start`. So this is removing the method to start it when cln will start, and running it with the deamon itself. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/fix-plugings
branch
from
698dea2
to
eb173e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside the CI we noted that the tests over the plugin get stuck and my suspection is that we had some problem to run the plugin with the
lightning-cli plugin start.So this is removing the method to start it when cln will start, and running it with the deamon itself.