Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate There is no Double Slash in root_path or exec_path #188

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Validate There is no Double Slash in root_path or exec_path #188

merged 1 commit into from
Jul 30, 2023

Conversation

tareknaser
Copy link
Collaborator

@tareknaser tareknaser commented Jul 30, 2023 •
edited by vincenzopalazzo
Loading

Fixes #141

@netlify
Copy link

netlify bot commented Jul 30, 2023 •
edited
Loading

✅ Deploy Preview for coffee-docs canceled.

Name Link
🔨 Latest commit 0861a3b
🔍 Latest deploy log https://app.netlify.com/sites/coffee-docs/deploys/64c6d56444acb40008863813

vincenzopalazzo
vincenzopalazzo requested changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was perfect, except for the panic

tests/src/coffee_integration_tests.rs Outdated Show resolved Hide resolved
@tareknaser
feat(tests): add a test to make sure there is no double slash
0861a3b 
Signed-off-by: Tarek <tareknaser360@gmail.com>
vincenzopalazzo
vincenzopalazzo approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@vincenzopalazzo vincenzopalazzo merged commit a282211 into coffee-tools:master Jul 30, 2023
9 checks passed
@tareknaser tareknaser deleted the double-slash-test branch July 31, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bad url inside the plugin struct in some cases
2 participants
@tareknaser @vincenzopalazzo