install command: add -T option to cp to not create nested folders on duplicate calls #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for coffee-docs canceled.
|
vincenzopalazzo
approved these changes
Feb 25, 2024
There was a problem hiding this comment.
LGTM waiting for @tareknaser that is the author of this feature for confimation
tareknaser
approved these changes
Feb 25, 2024
|
Just noticed that Seems like kubernetes had a similar issue before kubernetes/kubernetes#56383 |
you had an OSX iirc? did you not test on your machine before approving the PR? |
No I actually missed this one. I read the documentation for the flag online and thought it made perfect sense for a quick fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you call coffee install more than once it will create folders like this:
the -T option for cp should fix this.