git: adding basic function to checkout a branch #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for coffee-docs canceled.
|
This was referenced Mar 1, 2024
vincenzopalazzo
commented
Mar 7, 2024
| @@ -1,8 +1,10 @@ | |||
| use log::debug; | |||
| use tokio::process::Command; | |||
There was a problem hiding this comment.
wrong import place
tareknaser
suggested changes
Mar 7, 2024
There was a problem hiding this comment.
Thanks
Here are some notes as well:
- We need to update integration tests in
tests/src/coffee_integration_tests.rsto passbranchparameter tocoffee_install - coffee plugin needs to pass the
branchvalue as well. Seecoffee_plugin/src/plugin/plugin_mod.rs - We can also add a comment in the docs to mention the new parameter
| if let Some(branch) = branch { | ||
| // FIXME: Where we store the date? how we manage it? | ||
| let (commit, _) = | ||
| git_checkout(&plugin.root_path, &branch, verbose).await?; |
There was a problem hiding this comment.
We switch the whole repository to the required branch but we don't switch back to the original branch of the repository after installing the plugin
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/git-checkout
branch
from
d1159da to
4d7920d
Compare
|
Ok, this needs to go in before the first release, to fix the CI. We can add the remote with a specific commit when summary was sane |
Is this possible with git? What do you think? |
Yeah make sense to do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative version of #242
Fixes #205