Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tip function sent unwanted amount and expected wrong response #253

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

daywalker90
Copy link
Collaborator

When fetching an invoice with an amount and then paying that invoice cln will error if you've sent an amount on the pay command aswell.

Tip also expected an incompatible CoffeeTip response from pay. pay responses don't have a field for_plugin or invoice

tested with cln 24.02rc2

When fetching an invoice with an amount and then paying that invoice
cln will error if you sent an amount on the pay command aswell
Tip also expected an incompatible CoffeeTip response from pay
e.g. pay does not have a field 'for_plugin'
Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for coffee-docs canceled.

Name Link
🔨 Latest commit 41720cf
🔍 Latest deploy log https://app.netlify.com/sites/coffee-docs/deploys/65ddf4b8677a4c000888d4e2

Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for testing and patching it

@vincenzopalazzo vincenzopalazzo merged commit 71c7f30 into coffee-tools:master Mar 1, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants