Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][fn]Support for pulsar.service.url in the Local Run Mode for Debezium IO connectors #1

Closed
wants to merge 3 commits into from

Conversation

sandeep-mst
Copy link
Collaborator

Fixes 21276 of apache/pulsar

Motivation

Local run mode which is used for debugging functions doesn't support pulsar.service.url from Debezium IO connectors. It is always picking up the default value of "pulsar://localhost:6650".

Modifications

Modified so that it picks the broker url specified in "pulsar.service.url" from source or sink config if specified. The priority will be "--brokerServiceUrl" if specified and if not, it will pick up pulsar.service.url from source or sink config.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@sandeep-mst sandeep-mst changed the title Support for pulsar.service.url in the Local Run Mode for Debezium IO connectors [fix][fn]Support for pulsar.service.url in the Local Run Mode for Debezium IO connectors Mar 26, 2024
@HasanHaghniya
Copy link

any update for this?

@sandeep-mst
Copy link
Collaborator Author

Closing in favour of #7 on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants