Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nar unpacking #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for nar unpacking #15

wants to merge 3 commits into from

Conversation

nikhilerigila09
Copy link
Collaborator

Fixes apache#23273

Main Issue: apache#23273

Motivation

This PR addresses an issue where the Pulsar broker fails to restart due to incomplete NAR file extraction. The broker attempts to reuse an incomplete directory in the /tmp folder, leading to a NoSuchFileException. This occurs when the broker is stopped during the extraction process, causing the NAR files to remain in an inconsistent state, which affects future restarts.

Modifications

  • Implemented a ".success" file that is written after a NAR file is fully extracted.

  • On broker restart, the existence of the ".success" file is checked to ensure the NAR directory is valid. If the file is missing, the extraction process is restarted.

Verifying this change

  • Make sure that the change passes the CI checks.

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Broker Fails to Restart Due to Incomplete NAR File Extraction in /tmp Directory
1 participant