Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run yamllint in CI for this repository #26

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Run yamllint in CI for this repository #26

merged 1 commit into from
Mar 8, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 1, 2024

This change conflicts heavily with other PRs on this repo and won't pass CI until those changes are merged.

@cottsay cottsay self-assigned this Mar 1, 2024
nuclearsandwich
nuclearsandwich approved these changes Mar 2, 2024
View reviewed changes
Copy link

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several yamllint errors pop up around line length. I'd be fine configuring the length to 100, especially for deeply nested configs, but I see some strings have already been split across lines to meet the 80 char limit so either is fine with me.

.github/workflows/ci.yaml Show resolved Hide resolved
@cottsay
Copy link
Member Author

cottsay commented Mar 2, 2024

Several yamllint errors pop up around line length.

All three of the lines with issues are modified by #24 and should resolve when that PR is merged.

@cottsay cottsay marked this pull request as ready for review March 7, 2024 22:35
@cottsay cottsay merged commit 942ed2a into main Mar 8, 2024
21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/yamllint branch March 8, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees

@cottsay cottsay

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cottsay @nuclearsandwich