Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop codecov-action@v3, enable codecov by default #32

Merged
merged 1 commit into from
Jun 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
canary:
uses: ./.github/workflows/pytest.yaml
with:
codecov: false
# Choose colcon-notification for a canary build. It has colcon
# dependencies and debian patches, so exercieses a fair amount of the
# CI action features.
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/pytest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on: # yamllint disable-line rule:truthy
inputs:
codecov:
description: 'run codecov action after testing'
default: false
default: true
required: false
type: boolean
matrix-filter:
Expand Down Expand Up @@ -61,9 +61,7 @@ jobs:
repository: ${{ inputs.setup-repository }}
path: ./.github-ci-action-repo
- uses: ./.github-ci-action-repo
- uses: codecov/codecov-action@v3
if: ${{ inputs.codecov }}
- uses: codecov/codecov-action@v4
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
if: ${{ env.CODECOV_TOKEN != '' }}
if: ${{ inputs.codecov }}
Loading