Symlink python packages #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotu
force-pushed
the
symlink-instead-of-pythonpath
branch
from
c58a329
to
3207b54
Compare
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
+ Coverage 78.14% 80.43% +2.28%
==========================================
Files 54 54
Lines 3080 3087 +7
Branches 507 507
==========================================
+ Hits 2407 2483 +76
+ Misses 646 570 -76
- Partials 27 34 +7
Continue to review full report at Codecov.
|
dirk-thomas
reviewed
Sep 13, 2019
|
With #219 merged please rebase this one. |
rotu
force-pushed
the
symlink-instead-of-pythonpath
branch
from
8016577
to
0a7cf13
Compare
dirk-thomas
added
in progress
|
Thanks for fixing the test failure. This PR is not functionally correct yet, so don't worry about its test status. I should probably add a test PR to accompany this enhancement too. |
rotu
force-pushed
the
symlink-instead-of-pythonpath
branch
from
533cd5d
to
71d6beb
Compare
Previously, we either monkey-patched setuptools and harvested the arguments passed to setuptools.setup or we parsed setup.cfg Now we run the setup.py script with distutils.core.run_setup to return properties from the resulting Distribution object.
rotu
force-pushed
the
symlink-instead-of-pythonpath
branch
5 times, most recently
from
8fb54ea
to
264a054
Compare
|
State of this PR:
Things I don't love:
|
rotu
force-pushed
the
symlink-instead-of-pythonpath
branch
from
264a054
to
c042f29
Compare
Modify build tests to build in symlink mode as well
Eggs was a bad idea. They still have to each be in PYTHONPATH to work.
Only install subdirectories of Log installed files w/ symlink_install
rotu
force-pushed
the
symlink-instead-of-pythonpath
branch
from
c042f29
to
ac04854
Compare
|
@rotu Friendly ping to see if you are still interested in this? |
|
Definitely still interested in seeing this done. But I haven't had the cycles to see it through yet. You can close this PR if you like |
|
I was just checking - it can stay open if you want to pick it up again at some point. |
|
Superseded by #592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #218
When using
colcon build --symlink-install, install the packages with symlinks instead of using hooks to extend PYTHONPATH.