Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency fixes for test_executor_sequential #566

Merged
merged 1 commit into from
Aug 17, 2023

Commits on Aug 2, 2023

  1. Consistency fixes for test_executor_sequential

    A things things here:
    1. Use a real Job object like the other test. The sequential executor
       doesn't seem to need it to have a 'identifier' property, but other
       executors do and we should be consistent.
    2. Move stuff out of the try/finally block for the os.kill thread to
       reduce the likelihood of secondary exceptions.
    3. Clear the global job accumulation variable even though we don't use
       check it (which is another conversation entirely).
    cottsay committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    0cd49e7 View commit details
    Browse the repository at this point in the history